Skip to content

feat: add Qrevo S5V dock type code (22) to RoborockDockTypeCode - #829

Merged
Lash-L merged 2 commits into
Python-roborock:mainfrom
justprox:add-qrevo-s5v-dock-type
May 17, 2026
Merged

feat: add Qrevo S5V dock type code (22) to RoborockDockTypeCode#829
Lash-L merged 2 commits into
Python-roborock:mainfrom
justprox:add-qrevo-s5v-dock-type

Conversation

@justprox

Copy link
Copy Markdown
Contributor

Summary

  • Add qrevo_s5v_dock (code 22) to RoborockDockTypeCode enum in v1_code_mappings.py
  • Add the new dock type to WASH_N_FILL_DOCK_TYPES in device_features.py since the Qrevo S5V dock is a wash-and-fill dock
  • Add test coverage for the new dock type code

Context

The Roborock Qrevo S5V vacuum dock reports dock type code 22, which was not previously defined in the library. This caused a warning log on every Home Assistant startup:

Missing RoborockDockTypeCode code: 22 - defaulting to 'unknown'

While the _missing_ method gracefully falls back to unknown, this clutters logs and means the dock type isn't properly identified. The Qrevo S5V is a 2025 model with a multi-function wash dock (same dock family as the Qrevo Curv, code 17).

Changes

FileChange
roborock/data/v1/v1_code_mappings.pyAdded qrevo_s5v_dock = 22
roborock/device_features.pyAdded to WASH_N_FILL_DOCK_TYPES list
tests/data/v1/test_v1_containers.pyAdded test for code 22 recognition
tests/devices/traits/v1/test_wash_towel_mode.pyAdded qrevo_s5v_dock to parametrized tests
tests/devices/traits/v1/test_dust_collection_mode.pyAdded qrevo_s5v_dock to parametrized tests
tests/devices/traits/v1/test_smart_wash_params.pyAdded qrevo_s5v_dock to parametrized tests

All 56 affected tests pass.

@Lash-L

Copy link
Copy Markdown
Collaborator

Hey @justprox this seems to conflict with another PR that was merged, do you mind fixing conflicts?

@justprox

Copy link
Copy Markdown
ContributorAuthor

Done!

@Lash-L
Lash-L merged commit 8d8a443 into Python-roborock:mainMay 17, 2026
7 checks passed
@Lash-L

Copy link
Copy Markdown
Collaborator

Ty!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@justprox@Lash-L