Feature/HebrewView - #280

Open

elor555 wants to merge 71 commits into

PythonFreeCourse:developfrom

elor555:feature/hebrewview

elor555 commented Feb 14, 2021•
edited
Loading

Create a new feature- Adding a Hebrew date to each calendar date(on the dayview page)

elor555 added 2 commits

February 14, 2021 16:19

add hebrew dates to calendar-nre feature

33723a7

add test to hebrew dates

0d296f3

elor555 changed the title ~~add hebrew dates to calendar-nre feature~~Feature/HebrewView

elor555 added 4 commits

February 14, 2021 16:41

edit flake8

970534d

edit flake8

f0bc588

fix after pull

7282e00

edit flake8

861587a

ivarshav reviewed

View reviewed changes

app/internal/load_hebrew_view.py Outdated

ivarshav reviewed

View reviewed changes

app/internal/load_hebrew_view.py Outdated

ivarshav reviewed

View reviewed changes

app/internal/load_hebrew_view.py Outdated

ivarshav reviewed

View reviewed changes

app/internal/load_hebrew_view.py Outdated

ivarshav reviewed

View reviewed changes

app/main.py Outdated

ivarshav reviewed

View reviewed changes

app/main.py Outdated

ivarshav reviewed

View reviewed changes

app/routers/calendar.py Outdated

ivarshav reviewed

View reviewed changes

app/routers/hebrew_date.py Outdated

ivarshav reviewed

View reviewed changes

app/routers/hebrew_date.py Outdated

elor555 added 4 commits

February 16, 2021 00:09

edit

8426167

Merge branch 'develop' ofhttps://github.com/PythonFreeCourse/calendar…

6b28e84

…into feature/hebrewview

edit

fbdd7f5

edit

442a640

ivarshav reviewed

View reviewed changes

elor555 added 9 commits

February 16, 2021 20:34

check

e4720c8

check

fcefcbe

edit

9e6742e

edit

c63471a

edit after flake8

97a1d8c

edit after flake8

201b1d8

Merge branch 'develop' ofhttps://github.com/PythonFreeCourse/calendar…

739729e

…into feature/hebrewview

edit after flake8

d79b1c3

edit after flake8

f488161

edit

a3b0b95

IdanPelled reviewed

View reviewed changes

IdanPelled left a comment

Contributor

Very nice work.

For next time, please try and give more spasific commit messages read more.

app/internal/hebrew_date_view.py Outdated

tests/test_calendar_grid.py Outdated

Gonzom reviewed

View reviewed changes

app/internal/hebrew_date_view.py Outdated

app/internal/json_data_loader.py

app/routers/dayview.py Outdated

app/templates/calendar_day_view.html Outdated

app/templates/calendar_day_view.html

app/templates/calendar_day_view.html Outdated

elor555 added 4 commits

February 24, 2021 12:49

Merge branch 'develop' ofhttps://github.com/PythonFreeCourse/calendar…

be3ce04

…into feature/hebrewview

edit

408de5d

edit

848368f

edit

3e96b8b

yammesicka requested changes

View reviewed changes

app/internal/hebrew_date_view.py Outdated

app/internal/hebrew_date_view.py Outdated

app/routers/calendar.py

app/internal/hebrew_date_view.py Outdated

yammesicka commented Feb 24, 2021

Member

Also, please add some tests :)

elor555 added 2 commits

February 24, 2021 17:37

edit

34ebe6e

Merge branch 'develop' ofhttps://github.com/PythonFreeCourse/calendar…

4fa9da5

…into feature/hebrewview

yammesicka requested changes

View reviewed changes

app/internal/hebrew_date_view.py Outdated

yammesicka requested changes

View reviewed changes

app/internal/hebrew_date_view.py Outdated

elor555 added 17 commits

February 25, 2021 16:54

Merge branch 'develop' ofhttps://github.com/PythonFreeCourse/calendar…

a64fcd9

…into feature/hebrewview

Details Message

3b1a6be

Details Message

ed58474

fix: flake8

22f0bcc

fix: flake8

1a1eb3d

fix: bug fix

7d6ec9b

fix: bug fix

18a0195

fix: bug fix

c022096

fix: fix translation files

44f9d61

Merge remote-tracking branch 'upstream/develop' into feature/hebrewview

76726e1

# Conflicts:
#	app/routers/dayview.py

fix: bugfix

a2449d2

fix: bugfix

c7d3b7d

fix: bugfix

11fc0d6

fix: bugfix

377e82d

fix: styling

9b0c629

fix: bugfix

0a9a4fb

fix: bugfix

c48a270

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment