Skip to content

Feature/shabbatime - #333

Open
elor555 wants to merge 44 commits into
PythonFreeCourse:developfrom
elor555:feature/shabbatime
Open

Feature/shabbatime#333
elor555 wants to merge 44 commits into
PythonFreeCourse:developfrom
elor555:feature/shabbatime

Conversation

@elor555

@elor555elor555 commented Feb 23, 2021

Copy link
Copy Markdown

Create a new feature
In my feature, the shabbat time by the user location of the week are displayed every Saturday (on the dayview page).

i also made location class.
Needs further treatment:

  • style
  • place the location in the right place

@elor555
elor555 changed the base branch from main to developFebruary 23, 2021 23:56
Comment threadapp/internal/locations.py Outdated
Comment threadapp/internal/shabbat.py Outdated
Comment threadapp/internal/shabbat.py Outdated
Comment threadapp/database/models.py Outdated
Comment threadapp/resources/locations.json
Comment threadapp/routers/dayview.py Outdated
Comment threadapp/templates/calendar_day_view.html Outdated
Comment threadapp/templates/calendar_day_view.html Outdated
Comment threadapp/templates/calendar_day_view.html Outdated
@codecov-io

codecov-io commented Feb 27, 2021

Copy link
Copy Markdown

Codecov Report

Merging #333 (3e96f7d) into develop (5c2136b) will decrease coverage by 0.11%.
The diff coverage is 88.23%.

Impacted file tree graph

@@ Coverage Diff @@## develop #333 +/- ##
===========================================
- Coverage 94.43% 94.31% -0.12% 
===========================================
Files 91 90 -1 Lines 4257 4169 -88 ===========================================
- Hits 4020 3932 -88 
Misses 237 237 
Impacted FilesCoverage Δ
app/routers/dayview.py97.82% <77.77%> (-1.42%)⬇️
app/internal/locations.py78.94% <78.94%> (ø)
app/database/models.py97.37% <100.00%> (-0.10%)⬇️
app/internal/json_data_loader.py100.00% <100.00%> (ø)
app/internal/shabbat.py100.00% <100.00%> (ø)
app/internal/event.py95.71% <0.00%> (-0.92%)⬇️
app/main.py95.83% <0.00%> (-0.17%)⬇️
app/dependencies.py87.50% <0.00%> (ø)
app/routers/export.py82.35% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c2136b...bf56e9b. Read the comment docs.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@elor555@codecov-io@Gonzom