Set login form to use WTForms

[NogaOs]

No description provided.

[sourcery-ai]

Sourcery Code Quality Report

✅ Merging this PR will increase code quality in the affected files by 0.02%.

Quality metrics	Before	After	Change
Complexity	3.72 ⭐	3.66 ⭐	-0.06 👍
Method Length	52.73 ⭐	52.73 ⭐	0.00
Working memory	6.99 🙂	7.00 🙂	0.01 👎
Quality	74.57% 🙂	74.59% 🙂	0.02% 👍

Other metrics	Before	After	Change
Lines	612	616	4

Changed files	Quality Before	Quality After	Quality Change
lms/lmsweb/views.py	74.55% 🙂	74.56% 🙂	0.01% 👍
lms/lmsweb/forms/reset_password.py	75.87% ⭐	75.87% ⭐	0.00%

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
lms/lmsweb/views.py	comment	13 🙂	202 😞	8 🙂	50.15% 🙂	Try splitting into smaller methods
lms/lmsweb/views.py	view	8 ⭐	140 😞	10 😞	56.16% 🙂	Try splitting into smaller methods. Extract out complex expressions
lms/lmsweb/views.py	login	4 ⭐	127 😞	12 😞	57.91% 🙂	Try splitting into smaller methods. Extract out complex expressions
lms/lmsweb/views.py	note	6 ⭐	144 😞	8 🙂	61.90% 🙂	Try splitting into smaller methods
lms/lmsweb/views.py	shared_solution	2 ⭐	84 🙂	10 😞	69.27% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[yammesicka]

Great start! I've added few comments that can help improve this PR further :)

[yammesicka]

Should we keep the login message from the last page request or generate new one? (I might have missed something in the logic here)

[NogaOs]

I don't think I changed anything meaningful here. Me missing something in the logic here would be more probable :P
From just messing around with the system, it seems to work - what should I fix here?

[orronai]

Try to create a form validator instead of the auth method and because of that you would remove 113-122 lines.
You can take a look in the lmsweb/tools/validators.py and the auth method in order to create the validator

[yammesicka]

Please configure your IDE to convert TAB to 2 spaces in HTML

[yammesicka]

Please reindent it