Skip to content

[DA] Sinkhorn LpL1 transport to work on JAX - #592

Merged
cedricvincentcuaz merged 19 commits into
PythonOT:masterfrom
kachayev:jax-da-lpl1
Jun 24, 2024
Merged

[DA] Sinkhorn LpL1 transport to work on JAX#592
cedricvincentcuaz merged 19 commits into
PythonOT:masterfrom
kachayev:jax-da-lpl1

Conversation

@kachayev

Copy link
Copy Markdown
Collaborator

Types of changes

This PR presents a vectorized implementation of LpL1 transport algorithms for domain adaptation, along with all the requisite modifications to ensure compatibility of the ot.da module with JAX.

Motivation and context / Related issue

Continuing the effort to enable Domain Adaptation functionality in JAX. See also previously introduced changes in PR #587 for details.

How has this been tested (if it applies)

The tests have been updated. Additionally, a dedicated test has been included to verify that the vectorized implementation produces the same results as the original code.

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

@codecov

codecovBot commented Jan 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.66%. Comparing base (a8f0ed5) to head (ca00540).

Additional details and impacted files
@@ Coverage Diff @@## master #592 +/- ##
=======================================
Coverage 96.66% 96.66% =======================================
Files 85 85 Lines 16898 16928 +30 =======================================
+ Hits 16334 16364 +30 
Misses 564 564 

@kachayevkachayev changed the title [WIP] [DA] Sinkhorn LpL1 transport to work on JAX[DA] Sinkhorn LpL1 transport to work on JAXMay 29, 2024

@cedricvincentcuazcedricvincentcuaz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @kachayev,
sorry for the late review on this PR. I put some remarks to ensure compatibility with all backends. Could you take them into account and mention the fix in the RELEASE.md file ?

Best,
Cédric

Comment threadot/da.py Outdated
Comment threadtest/test_da.py Outdated
@cedricvincentcuaz
cedricvincentcuaz merged commit 2941ed3 into PythonOT:masterJun 24, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kachayev@cedricvincentcuaz@rflamary