Skip to content

Added drop of columns containing only NANs - #142

Merged
patrickleonardy merged 4 commits into
developfrom
138-NaN-column-not-preprocessed-properly
Dec 7, 2022
Merged

Added drop of columns containing only NANs#142
patrickleonardy merged 4 commits into
developfrom
138-NaN-column-not-preprocessed-properly

Conversation

@patrickleonardy

@patrickleonardypatrickleonardy commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

Story Title

NaN column not preprocessed properly #138

Changes made

  • Added _check_nan_columns_and_drop_columns_containing_only_nan function in PreProcessor. This function puts out warnings if a columns contains NaN values and drop columns that contain only missing values.

How does the solution address the problem

This PR will let the preprocessor drop automatically columns containing only missing values and write a warning if the dataset contains missing values and if a columns containing only missing values is dropped

Linked issues

Resolves#138

@patrickleonardy
patrickleonardy requested review from ZlaTanskY and sborms and removed request for sbormsDecember 5, 2022 12:16
ZlaTanskY
ZlaTanskY requested changes Dec 5, 2022
View reviewed changes
Comment threadcobra/preprocessing/preprocessor.py Outdated
Comment threadcobra/preprocessing/preprocessor.py Outdated
Comment threadcobra/preprocessing/preprocessor.py Outdated
Comment threadtests/preprocessing/test_preprocessor.py Outdated
Comment threadtests/preprocessing/test_preprocessor.py Outdated
Comment threadcobra/preprocessing/preprocessor.py Outdated
Comment threadcobra/preprocessing/preprocessor.py
@patrickleonardy
patrickleonardy merged commit 03372ea into developDec 7, 2022
@patrickleonardy
patrickleonardy deleted the 138-NaN-column-not-preprocessed-properly branch December 7, 2022 10:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZlaTanskYZlaTanskYZlaTanskY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NaN column not preprocessed properly

2 participants

@patrickleonardy@ZlaTanskY