Uh oh!
There was an error while loading. Please reload this page.
Simplify installation path configuration - #697
Conversation
Removed unnecessary path normalization and appending for installation.
otbrown
commented
Oct 24, 2025
Thanks for this Erich, I have two minor requests before merge:
|
Making the binaries specifically still be prepended by |
eessmann
commented
Oct 24, 2025
I don't think we should install the executables, they are all just examples. |
otbrown
commented
Oct 27, 2025
Good point. I was pondering over the weekend, and I can think of one or two awkward workflows where the user might want binaries installed too (i.e. when the user sets an install prefix and is using the USER_SOURCE option), so rather than remove the binary install entirely I was thinking ye olde create a CMake option.
|
Modifies CMakeLists to conditionally build shared libraries and install binaries only at the top-level project. Introduces the INSTALL_BINARIES option to control the inclusion of example binaries in the installation process. Corrects a typo from 'RATH' to 'RPATH' for build configurations.
eessmann
commented
Oct 27, 2025
Oliver, I’ve added your suggested option so we’re now conditionally installing the examples. I’ve also made it so that if we’re the top-level CMake project, we set the type of library we build to shared. I encountered a bug when using Quest with the CMake FetchContent feature; Quest’s BUILD_SHARED_LIBS setting leaked into my build. |
otbrown
commented
Oct 27, 2025
Excellent, thanks Erich! |
Uh oh!
There was an error while loading. Please reload this page.
Removed unnecessary path normalization and appending for installation.
closes#696