Skip to content

Forgetting/projection. - #16

Merged
haz merged 4 commits into
masterfrom
projection
Aug 7, 2020
Merged

Forgetting/projection.#16
haz merged 4 commits into
masterfrom
projection

Conversation

@haz

@hazhaz commented Aug 6, 2020•
edited
Loading

Copy link
Copy Markdown
Collaborator

Closes#7

@haz
haz requested a review from blyxxyzAugust 6, 2020 15:17
blyxxyz
blyxxyz reviewed Aug 6, 2020
View reviewed changes
Comment threadnnf/__init__.py Outdated
blyxxyz
blyxxyz reviewed Aug 6, 2020
View reviewed changes
Comment threadnnf/__init__.py Outdated
blyxxyz
blyxxyz requested changes Aug 6, 2020
View reviewed changes

@blyxxyzblyxxyz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a bunch of nitpicks, but this looks good overall.

Comment threadnnf/__init__.py Outdated
Comment threadnnf/__init__.py Outdated
Comment threadtest_nnf.py Outdated
Comment threadnnf/__init__.py Outdated
Comment threadnnf/__init__.py Outdated
Comment threadtest_nnf.py
Comment threadtest_nnf.py Outdated
Comment threadnnf/__init__.py Outdated
Comment threadnnf/__init__.py Outdated
Comment threadnnf/__init__.py Outdated
blyxxyz
blyxxyz requested changes Aug 7, 2020
View reviewed changes

@blyxxyzblyxxyz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One last thing, and then we're done.

(You can build the docs locally to see how they turn out by running make html in the docs/ directory)

Comment threadnnf/__init__.py Outdated
@haz

haz commented Aug 7, 2020

Copy link
Copy Markdown
CollaboratorAuthor

Should we wait until #17 before merging this?

blyxxyz
blyxxyz approved these changes Aug 7, 2020
View reviewed changes

@blyxxyzblyxxyz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this looks fine to merge now.

@haz
haz merged commit b102a3c into masterAug 7, 2020
@hazhaz mentioned this pull request Aug 7, 2020
Closed
@blyxxyz
blyxxyz deleted the projection branch August 7, 2020 21:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blyxxyzblyxxyzblyxxyz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement forgetting/projection

2 participants

@haz@blyxxyz