Record two repository facts the 2026-09-07 validation got wrong - #141
Merged
Conversation
Two boxes of the #127 validation checklist failed on facts about this repository that nothing wrote down. Recording them where a checklist author looks stops the next validation issue from asking for the impossible. **The git history is complete.** The validation refuted the pure-rename box on the grounds that this repository has a single root at `931d626` (#57) with 50 commits, so no commit for the 2026-07-16 flatten exists. That is a shallow clone reading its own depth as the repository's history: `931d626` is an ordinary commit with parent `c044b8c`, and it is precisely the 50th ancestor of `818811b`, the head the checklist was written against. `git clone --depth=50` there reproduces the signature exactly. The real root is `77ece40` (2025-02-09) and `git log --follow` does cross the flatten. What goes into the file is the true statement plus the one-line check that would have caught it. **The hash gate covers every recorded file.** `check_consumed_files.py` hashes anything with an `integrity.sha256` whether or not `consumers` is populated — the deliberate rekeying in #56 — so `consumed-files` goes red for any change to a published file's bytes. A checklist that wants the schema gate isolated must mutate a manifest, not the data. Also, beyond the issue's scope but in the same family and verified the same way: the repo map said "41 datasets, 41 manifests", which has been three short since #114 landed the business_cycle set on 2026-09-01. The tree holds 44 of each. Documentation only; no code, no manifest fields, no data bytes. Closes #138. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
Documentation-only update, and the key operational claim about sha256 hashing is consistent with the current check_consumed_files.py behavior.
Pull request overview
This PR updates AGENTS.md to record two repository facts that were previously misstated in a validation checklist, so future validations don’t rely on incorrect assumptions (notably around shallow clones and the consumed-file hash gate).
Changes:
- Correct the repo-map dataset/manifest count to 44 (and note the
business_cycleset addition). - Document that the repository’s git history is complete (and that “50 commits / root at
931d626” is a shallow-clone artifact). - Document that
check_consumed_files.pyenforces sha256 integrity wheneverintegrity.sha256is recorded, regardless ofconsumers.
File summaries
| File | Description |
|---|---|
| AGENTS.md | Updates repo-map counts and records two validation-relevant repository facts (git history completeness; sha256 hashing behavior independent of consumers). |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two boxes of the #127 checklist failed on facts about this repository that nothing wrote down. Recording them where a checklist author looks stops the next validation issue asking for the impossible.
One of the two facts as #138 stated it is false, and re-measuring before writing is the reason this PR is worth reading rather than rubber-stamping.
Fact 1, corrected
#138 asked to record: "The git history begins at #57. This repository has a single root commit,
931d626, and 50 commits in total ... a check phrased asgit log --followreaches #10 cannot be satisfied."Every clause of that is false.
mainat47017ea931d626931d626is an ordinary commit with parentc044b8c; 54 commits precede it. The API confirms it — a true root hasparents: []c0adb7a, 2025-02-1352dbb89, the merge commit of #10,mergedAt2026-07-16T22:45:04Z--followcannot reach #1052dbb89, and continues tob857c5c(2025-02-16)It is a shallow clone reading its own depth as the repository's history.
git rev-list --count 931d626..818811bis 49, so931d626is precisely the 50th ancestor of818811b— the head #127 was written against.git clone --depth=50there reproduces the finding bit for bit: 50 commits,rev-list --max-parents=0returning931d626alone,--followstopping short of the flatten. A shallow boundary hides its parents, so it is indistinguishable from a root.What goes into the file is therefore the true statement plus the one-line check that would have caught it. Recording #138's version would have put a falsehood into
AGENTS.mdthat the next validator would trust — and #127 §2.2 is confirmed as written, not "not completable".Fact 2, as written
check_consumed_files.pyhashes every file whose manifest records anintegrity.sha256, with or withoutconsumers— the deliberate rekeying in #56, because manifests land ahead of their repoints and keying onconsumersmade the one PR that introduces new bytes the one PR that never verified them. The consequence for a checklist:consumed-filesgoes red for any change to a published file's bytes. Measured on #130 — a manifest-only mutation left it green with onlyvalidatered; appending a column togdp_growth_annual.csvturned both red.Beyond the issue's scope, flagged rather than slipped in
The repo map said "41 datasets, 41 manifests". That has been three short since #114 landed the business_cycle set on 2026-09-01; the tree holds 44 of each, and
CATALOG.mdalready says 44. Same family, one line, fixed here.Documentation only; no code, no manifest fields, no data bytes.
Closes #138.
🤖 Generated with Claude Code