Skip to content

Delete committed dataset orphans (Track X) - #844

Merged
mmcky merged 3 commits into
mainfrom
track-x-orphans
Sep 1, 2026
Merged

Delete committed dataset orphans (Track X)#844
mmcky merged 3 commits into
mainfrom
track-x-orphans

Conversation

@mmcky

@mmcky mmcky commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Deletes the three unreferenced files under lectures/datasets/ and the shadowed lectures/graph.txt, in separate commits, and adds lectures/graph.txt to .gitignore so a local run of short_path.md cannot re-commit it.

path why it is an orphan
datasets/GDP_per_capita_world_bank.csv no reference anywhere; the QuantEcon/data copy was dropped at Phase 2
datasets/Metadata_Country_API_NY.GDP.PCAP.CD_DS2_en_csv_v2_4770417.csv metadata twin of the file above
datasets/fig_3.ods source-format twin of fig_3.xlsx; referenced by nothing
graph.txt short_path regenerates it with %%file before reading it — the build prints Overwriting graph.txt — so the committed bytes are never consumed

Published surface: none. lectures/datasets/ and the lectures root sit outside html_static_path, and all four paths are 404 on intro.quantecon.org today (_static/qe-logo.png 200 control). Their only reader surface was raw.githubusercontent.com, so this deletion is complete on merge — no settle window, no rows for QuantEcon/workspace-lectures#40.

The graph.txt decision. One reader outside the organisation fetches this repo's committed copy by URL at runtime: devopseng99/project.lecture-wasm book/short_path.md:276 (still HTTP 200 today). Recorded on QuantEcon/workspace-lectures#57 before this PR was opened: accept the outside-org exposure, the same ruling as QuantEcon/workspace-lectures#38 — the lectures are open source, that project is a snapshot its owner controls, and the one-line remedy is to embed the data with %%file exactly as this lecture does. Inside the organisation the same 4,691-byte blob is committed in eight other repos (lecture-dp, lecture-intro.zh-cn, lecture-python.zh-cn, test-actions-lecture-intro, lecture-dp.monorepo, ipynb_pdf_constructor, QuantEcon.lectures.code, QuantEcon.jl), none of them read by URL; the lecture-repo copies are deleted in this set, the rest are out of scope.

Sibling: lecture-wasm deletes its mirror copies of the two World Bank files in the PR of the same title; lecture-intro.zh-cn deletes the same four paths. Nothing in either reads this repo's copies.

Deletion-time reader sweep (2026-09-01). Authenticated tarball-and-grep pass over 407 repositories: all 283 QuantEcon org repos (70 private, 26 archived; numfocus, quantecon-book-dp and test-cli are empty and unfetchable) plus 130 forks of the six holding repos (2 returned 404 and are recorded as not-swept rather than clean). Matched by basename, not URL, with each hit's three preceding lines folded in because URLs get split across source lines. Controls fired in the same pass: a never-existing basename returned 0 hits and 0 copies, and both known readers were found — the English python_advanced_features.md exercise link to test_table.csv, and devopseng99/project.lecture-wasm's runtime fetch of intro's graph.txt. Result: no repository reads any path this PR deletes. Every other co-occurrence of these basenames is a %%file embed, prose, a .gitignore line, or review text; the pre-MyST master/source/… reads in old course repos have been dead since the MyST migration and are unaffected.

Part of the Track X orphan sweep, QuantEcon/workspace-lectures#57 (one PR per holding repo, identical titles). Source list: https://quantecon.github.io/data-lectures/audit.json orphans, 2026-08-31 run.

🤖 Generated with Claude Code

mmcky and others added 3 commits September 1, 2026 10:04
These files are committed but read by nothing: the audit at https://quantecon.github.io/data-lectures/audit.json (2026-08-31 run) lists them under orphans, and an authenticated content sweep of 407 repositories (283 QuantEcon org repos plus the forks of the six holding repos, by basename, positive and negative controls in the same pass) on 2026-09-01 found no reader of these paths. Tracker: QuantEcon/workspace-lectures#57.

The two World Bank files were superseded when the GDP-per-capita lecture moved to data-lectures and their QuantEcon/data copy was dropped at Phase 2; fig_3.ods is the source-format twin of fig_3.xlsx, referenced by nothing.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
short_path regenerates graph.txt with %%file before reading it, so the committed bytes are never consumed (the build prints 'Overwriting graph.txt'). Every consumer in the organisation embeds the data the same way since QuantEcon/lecture-wasm#63.

One reader outside the organisation fetches this repo's committed copy by URL at runtime: devopseng99/project.lecture-wasm book/short_path.md:276. Decision recorded on QuantEcon/workspace-lectures#57: accept the outside-org exposure, as for the earlier deletions in QuantEcon/workspace-lectures#38 — the project can embed the data as this lecture does.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
A local run of short_path.md writes lectures/graph.txt into the working tree; ignoring it prevents the deleted copy from being re-committed by a later git add -A.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 1, 2026 00:07
@netlify

netlify Bot commented Sep 1, 2026

Copy link
Copy Markdown

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 0a35230
🔍 Latest deploy log https://app.netlify.com/projects/taupe-gaufre-c4e660/deploys/6a961753eaf05c00089c0a9a
😎 Deploy Preview https://deploy-preview-844--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes orphaned, unreferenced dataset artifacts and deletes a committed graph.txt that is regenerated during the short_path.md lecture execution, preventing it from being accidentally re-committed.

Changes:

  • Deleted the committed lectures/graph.txt (its contents are embedded and rewritten via %%file in short_path.md).
  • Deleted an unreferenced World Bank metadata CSV under lectures/datasets/.
  • Added lectures/graph.txt to .gitignore to prevent re-commits of the regenerated file.

Reviewed changes

Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.

File Description
lectures/graph.txt Removes a committed graph data file that is generated during lecture execution.
lectures/datasets/Metadata_Country_API_NY.GDP.PCAP.CD_DS2_en_csv_v2_4770417.csv Deletes an orphaned dataset metadata file with no in-repo references.
.gitignore Ignores regenerated lectures/graph.txt to prevent accidental re-commit.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

@github-actions
github-actions Bot temporarily deployed to pull request September 1, 2026 00:15 Inactive
@mmcky

mmcky commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Validation (2026-09-01, preview 6a961922…--taupe-gaufre): all four deleted paths → 404 (datasets/GDP_per_capita_world_bank.csv, the Metadata twin, datasets/fig_3.ods, graph.txt); short_path.html → 200 (95,815 B). Rendered short_path.html carries the %%file graph.txt cell and no raw.githubusercontent.com/…/lecture-python-intro/main/lectures/graph.txt reference; french_rev.html reads data-lectures (2 refs) and never mentions fig_3.ods. Build log: 0 warnings mentioning any deleted basename. The preview restored the 2026-08-31T03:17Z build-cache and still 404s these paths because they were never under html_static_path — they had no published surface to begin with.

@mmcky
mmcky merged commit 9241743 into main Sep 1, 2026
9 checks passed
@mmcky
mmcky deleted the track-x-orphans branch September 1, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants