ci: skip the stamp only on the bot's own subject line, not on any mention - #36
Merged
Merged
Conversation
…tion #35's squash commit carried its PR body, which mentioned "[skip-stamp]" in prose, so the guard skipped the very stamp run that PR shipped; the backfill had to be dispatched by hand. Match the bot's subject line with startsWith instead of contains on the whole message. Assisted-by: Claude Code (Claude Fable 5.1) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped to the workflow guard logic and aligns the workflow behavior with the intended “skip only on the bot’s subject line” semantics.
Pull request overview
Updates the stamp-version GitHub Actions workflow guard so the post-merge stamping job is skipped only for the bot’s own stamp commit subject line, avoiding accidental skips when a squash-merge commit body merely mentions [skip-stamp].
Changes:
- Replace
contains(...)on the full commit message withstartsWith(...)on the bot’s exact stamp commit subject line. - Add inline workflow comments documenting the squash-merge body behavior that caused #35’s stamp run to be skipped.
File summaries
| File | Description |
|---|---|
| .github/workflows/stamp-version.yml | Narrows the “skip stamp” guard to match only the bot’s stamp commit subject line, preventing PR-body mentions from skipping the job. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
A workflow_dispatch payload has no head_commit, so the guard was already inert on manual runs; say so in the expression rather than relying on the missing field. Assisted-by: Claude Code (Claude Fable 5.1) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When #35 merged, the stamp job was skipped: the squash commit carried the PR body, which mentioned the bot's marker in prose (the sentence about a manual run starting from the bot's own commit), and the guard uses
containsover the whole message. So the stamp that PR shipped did not run on its own merge and had to be dispatched by hand.This changes the guard to
startsWithon the bot's exact subject line. The stamp script's own equivalent check already reads the subject only. Any PR whose description discusses the marker no longer skips its own stamp.Assisted-by: Claude Code (Claude Fable 5.1)
🤖 Generated with Claude Code