Skip to content

fix: harden Dependabot automation - #310

Merged
Pigbibi merged 3 commits into
mainfrom
codex/dependabot-hygiene-20260811
Aug 11, 2026
Merged

fix: harden Dependabot automation#310
Pigbibi merged 3 commits into
mainfrom
codex/dependabot-hygiene-20260811

Conversation

@Pigbibi

@PigbibiPigbibi commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • use GitHub native auto-merge so eligible dependency PRs wait for every required check
  • keep major, Docker, GitHub Actions, and internal QuantStrategyLab updates manual
  • preserve the exact Dependabot PR head-SHA guard
  • narrow CODEOWNERS to risk and broker-sensitive source paths
  • disable the reactive review-request cleanup trigger while retaining a static-gate-compatible tombstone

Root cause

The merge workflow ran before other required checks completed. Separately, review-request cleanup ran only after GitHub had already sent the notification.

Validation

  • actionlint
  • semantic merge-policy cases: routine minor, major, Docker, GitHub Actions, internal dependency
  • git diff --check

No business logic, deployment, runtime, broker, order, or capital behavior is changed.

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi marked this pull request as ready for review August 11, 2026 05:29
Co-Authored-By: Codex <noreply@openai.com>

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:66600c9b79

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread.github/CODEOWNERS
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi merged commit 9bd7b11 into mainAug 11, 2026
2 checks passed
@Pigbibi
Pigbibi deleted the codex/dependabot-hygiene-20260811 branch August 11, 2026 05:42

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:ca729add37

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread.github/CODEOWNERS
/src/quant_platform_kit/common/models.py @Pigbibi
/src/quant_platform_kit/common/port_adapters.py @Pigbibi
/src/quant_platform_kit/common/execution_translation.py @Pigbibi
/src/quant_platform_kit/position_sizing.py @Pigbibi

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Cover remaining shared execution modules

The fresh evidence in this revision is that the expanded allowlist still stops after four shared files, while a repo-wide search shows other unowned order-critical modules: common/ports.py:23 defines the core submit_order port, common/execution_state.py:164 detects prior executions, and common/order_status.py:130 normalizes execution reports. When a PR changes any of these modules, GitHub will request no code-owner review and cannot require code-owner approval, despite the stated order-sensitive scope; add ownership patterns for the remaining shared execution paths.

Useful? React with 👍 / 👎.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Pigbibi