Uh oh!
There was an error while loading. Please reload this page.
ci: add the org nightly starter - #180
Conversation
Copy the Quantum-L9/.github l9-nightly.yml template so this repo schedules the one Core ci_deep kernel.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
There was a problem hiding this comment.
🟡 Changes recommended
The new workflow is misconfigured for this repo (missing packages: read permissions needed for GitHub Packages installs and language is set to python instead of typescript).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds the Quantum-L9 org “nightly starter” workflow to this repo so it runs the pinned l9-ci-core reusable nightly kernel on a schedule (and via manual dispatch), aligning the repository with the org-standard deep CI entrypoint.
Changes:
- Introduces
.github/workflows/l9-nightly.ymlwith a nightly cron trigger plusworkflow_dispatch. - Invokes
Quantum-L9/l9-ci-core/.github/workflows/nightly.ymlpinned to0d3d8d3cf2828e1a8c01c237597feb3979c2ba52and forwards inputs.
File summaries
| File | Description |
|---|---|
| .github/workflows/l9-nightly.yml | Adds a scheduled + manual trigger workflow that calls the pinned org nightly reusable kernel. |
Review details
Suppressed comments (1)
.github/workflows/l9-nightly.yml:18
- Job-level permissions omit
packages: read, which is required for the called reusable workflow to read GitHub Packages when usingNODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}.
permissions:
actions: read
checks: write
contents: read
- Files reviewed: 1/1 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| permissions: | ||
| contents: read |
| with: | ||
| python-version: "3.12" | ||
| run-extended-tests: true | ||
| language: python |
| # Quantum-L9 org starter — org nightly (ci_deep analyze-semgrep + full-tree tests). | ||
| # Thin trigger only. Calls the l9-ci-core nightly kernel; do not add scan logic here. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:bca7bf1ded
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| with: | ||
| python-version: "3.12" | ||
| run-extended-tests: true | ||
| language: python |
There was a problem hiding this comment.
With language: python, every scheduled or manual nightly run targets the Python path even though this repository's implementation and test commands are TypeScript/Node (package.json) and the existing governed analysis uses TypeScript/JavaScript rulesets. As a result, the advertised full-tree tests and language-specific analysis do not exercise the Website Factory; pass the reusable workflow's supported TypeScript/Node language value and matching runtime inputs instead.
AGENTS.md reference: AGENTS.md:L18-L22
Useful? React with 👍 / 👎.
| permissions: | ||
| actions: read | ||
| checks: write | ||
| contents: read |
There was a problem hiding this comment.
When the nightly kernel reaches its advertised analyze-semgrep SARIF publication path, this caller caps the reusable workflow's token at actions, checks, and contents, so the called workflow cannot obtain security-events: write. The repository's equivalent analysis workflow explicitly documents at .github/workflows/l9-analysis.yml:27-32 that omitting this grant causes the reusable publication workflow to be rejected at startup; add the permission here so nightly analysis can run.
Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.
Summary
l9-nightly.ymlstarter so this repo schedules the one Coreci_deepkernel.0d3d8d3cf2828e1a8c01c237597feb3979c2ba52(feat(ci): make nightly.yml the org ci_deep kernel l9-ci-core#132).Test plan
on.schedulenightlyworkflow_dispatchafter Core build(deps): bump Quantum-L9/l9-ci-core/.github/actions/build-artifact-manifest from 373bb6d26084e67ef76aaab95021364182a34ee7 to 0d28395428426853c44825c4645c23ee8ace23b1 #132 is on the pinMade with Cursor