Uh oh!
There was an error while loading. Please reload this page.
replace !iszero(x) with x !== zero(x) - #7
Open
davidschlegel wants to merge 3 commits into
Open
Conversation
To work with symbolic numbers.
| @inline function increaseindex!(a::SparseArray{T,N}, v, I::CartesianIndex{N}) where {T,N} | ||
| @boundscheck checkbounds(a, I) | ||
| iszero(v) && return | ||
| v !== zero(v) && return |
There was a problem hiding this comment.
Sorry, should be v == zero(v) of course.
| currentv = h.vals[index] | ||
| newv = currentv + convert(T, v) | ||
| if iszero(newv) | ||
| if v !== zero(newv) |
There was a problem hiding this comment.
Sorry, should be v == zero(v) of course.
| d = SparseArray{T,N}(undef, size(a)) | ||
| for I in CartesianIndices(a) | ||
| iszero(a[I]) && continue | ||
| v !== zero(a[I]) && continue |
There was a problem hiding this comment.
Sorry, should be v == zero(v) of course.
Jutho
commented
Oct 11, 2024
Member
Sorry for not responding sooner; could you briefly comment on why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To work with symbolic numbers.