Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinning
next,react, andreact-domto exact versions (15.3.6/19.1.2) ensures the security patch is applied, but it also removes any ability to receive compatible patch updates automatically. That can make it easier to drift out of date and requires more manual maintenance, especially for security patches released after these versions.Given this PR’s goal (patching a specific CVE), it would be safer long-term to keep the caret (
^) range but set the minimum version to the patched one (e.g.,^15.3.6,^19.1.2). That guarantees this fix while still allowing future non-breaking patch updates within the same major version.Suggestion
Consider using caret ranges with the patched versions as the minimum, e.g.:
This keeps you on secure, fixed minimum versions while still allowing safe patch-level updates in the same major line. Reply with "@CharlieHelps yes please" if you'd like me to add a commit with this suggestion.