Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
statusStream.done()is only called on the success path. IfrunMapGraph(...)throws, the UI stream created bycreateStreamableUI(<MapStatus ... />)may never be finalized, which can leave the client in a perpetual “loading”/spinner state and potentially leak resources.This is particularly likely given MCP/network calls in the graph. Finalizing the stream in a
finallyblock (or calling.error(...)/.done()in thecatch) will make the UI deterministic.Suggestion
Move
statusStream.done()into afinallyto guarantee termination, and optionally update status on failure.Reply with "@CharlieHelps yes please" if you'd like me to add a commit with this change.