Skip to content

Add image preview to ChatPanel#551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ngoiyaeric wants to merge 1 commit into from
Closed

Add image preview to ChatPanel #551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions components/chat-panel.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@ export const ChatPanel = forwardRef<ChatPanelRef, ChatPanelProps>(({ messages, i
const { mapProvider } = useSettingsStore()
const [isMobile, setIsMobile] = useState(false)
const [selectedFile, setSelectedFile] = useState<File | null>(null)
const [previewUrl, setPreviewUrl] = useState<string | null>(null)
const [suggestions, setSuggestionsState] = useState<PartialRelated | null>(null)
const setSuggestions = useCallback((s: PartialRelated | null) => {
setSuggestionsState(s)
Expand DownExpand Up@@ -156,6 +157,16 @@ export const ChatPanel = forwardRef<ChatPanelRef, ChatPanelProps>(({ messages, i
},
[mapData, setSuggestions]
)
useEffect(() => {
if (selectedFile && selectedFile.type.startsWith("image/")) {
const url = URL.createObjectURL(selectedFile)
setPreviewUrl(url)
return () => URL.revokeObjectURL(url)
} else {
setPreviewUrl(null)
}
}, [selectedFile])


useEffect(() => {
inputRef.current?.focus()
Expand DownExpand Up@@ -290,9 +301,20 @@ export const ChatPanel = forwardRef<ChatPanelRef, ChatPanelProps>(({ messages, i
</div>
</form>
{selectedFile && (
<div className="w-full px-4 pb-2 mb-2">
<div className="flex items-center justify-between p-2 bg-muted rounded-lg">
<span className="text-sm text-muted-foreground truncate max-w-xs">
<div className="w-full px-4 pb-2 mb-2" data-testid="attached-image">
<div className="relative flex items-center justify-between p-2 bg-muted rounded-lg group">
{previewUrl ? (
<div className="relative mr-2">
{/* eslint-disable-next-line @next/next/no-img-element */}
<img
src={previewUrl}
alt="Preview"
className="h-16 w-16 object-cover rounded-md border border-border"
data-testid="image-preview"
/>
Comment on lines +308 to +314

@charliecreatescharliecreatesBotFeb 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inline // eslint-disable-next-line @next/next/no-img-element is a pretty broad escape hatch and will likely spread. Since this is a preview of a local blob URL, you can still use next/image safely (it supports blob: URLs) and avoid disabling the rule.

This also gives you better defaults (lazy loading/decoding) and consistent sizing behavior.

Suggestion

Replace the raw <img> with next/image and remove the ESLint disable. Example:

importImagefrom"next/image"{previewUrl ? (<divclassName="relative mr-2 h-16 w-16"><Imagesrc={previewUrl}alt={`Preview of ${selectedFile.name}`}fillclassName="object-cover rounded-md border border-border"unoptimized/></div>) : null}

Reply with "@CharlieHelps yes please" if you’d like me to add a commit with this change.

</div>
) : null}
<span className="text-sm text-muted-foreground truncate max-w-xs flex-1">
{selectedFile.name}
</span>
<Button variant="ghost" size="icon" onClick={clearAttachment} data-testid="clear-attachment-button">
Expand Down