Change all instances of h1::text to h1 span::text when scraping Wiki's article page titles - #112
Open
ACPK wants to merge 1 commit into
Open
Change all instances of h1::text to h1 span::text when scraping Wiki's article page titles#112ACPK wants to merge 1 commit into
ACPK wants to merge 1 commit into
Conversation
This change reflects a change to Wikipedia's html structure. Old Wikipedia page: ```<h1>Title</h1>``` I Old Wikipedia page:: ```<h1><span>Title</span></h1>```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: Change all instances of
h1::texttoh1 span::textwhen scraping WikiThis change reflects a change to Wikipedia's html structure.
Old Wikipedia page:
<h1>Title</h1>Old Wikipedia page::
<h1><span>Title</span></h1>