Uh oh!
There was an error while loading. Please reload this page.
Fix creating bots in other drives than $tmp - #26
Merged
Conversation
| import unicodedata | ||
| normalized = unicodedata.normalize('NFKD', text).encode('ascii', 'ignore').decode() | ||
| valid_chars = "-_.() %s%s" % (string.ascii_letters, string.digits) | ||
| valid_chars = '-_.() %s%s' % (string.ascii_letters, string.digits) |
Member
There was a problem hiding this comment.
use str.format here instead since we're using python3.
ContributorAuthor
There was a problem hiding this comment.
Used f-strings as we are already at python 3.6 :)
| download_and_extract_zip( | ||
| download_url="https://github.com/RLBot/RLBotPythonExample/archive/master.zip", | ||
| local_zip_path=f"{tmpdirname}/RLBotPythonExample.zip", local_folder_path=tmpdirname) | ||
| download_url='https://github.com/RLBot/RLBotPythonExample/archive/master.zip', |
Member
There was a problem hiding this comment.
Single versus double quotes should be discussed and applied as project-wide change in a new PR, TODO
ContributorAuthor
There was a problem hiding this comment.
Acknowledged. Maybe introducing an auto-fixing linter would be the most effective tool to do this.
I've made things consistently use single quotes here as that was the dominant quoting style in this file. I don't have strong opinions on which quotes to use (although I prefer single quotes) but like things being consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue is here: #20
Also includes some quality of life changes.