Revert "[ROCM-26731] Exclude external PRs from CI GitHub action" - #5263
Merged
Merged
Conversation
This reverts commit 6374690.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Restore the fork guard or isolate the self-hosted runner before allowing external PR execution.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Reverts the CI restriction excluding external pull requests, re-enabling forked PR execution across CI jobs.
Changes:
- Removes fork guards from Ubuntu and SLES image builds.
- Removes guards from tidy, cppcheck, and SLES jobs.
File summaries
| File | Description |
|---|---|
.github/workflows/ci.yaml |
Re-enables external PR execution across CI jobs; fork-controlled Docker builds can run on a self-hosted runner. |
Review details
Suppressed comments (4)
.github/workflows/ci.yaml:100
- [agent]: This also enables fork PRs to run the checkout-controlled SLES Dockerfile on the
ROCM-Ubuntuself-hosted runner, so its build steps execute untrusted PR content there. Restore the fork guard (or isolate this job on a hosted runner) before re-enabling external PRs.
if: ${{ needs.check_image.outputs.imageexists_sles != 'true' }}
.github/workflows/ci.yaml:127
- [agent]: Because
build_imageis normallyskippedwhen the cached image exists, this condition now lets fork PRs reachtidyon the self-hostedROCM-Ubunturunner, where the checked-out PR is mounted into Docker and configured by CMake. Restore the fork guard here as well, or use an isolated runner.
if: ${{ !cancelled() && (needs.build_image.result == 'success' || needs.build_image.result == 'skipped') }}
.github/workflows/ci.yaml:285
- [agent]: This re-enables fork PRs in the
slesjob on the self-hostedROCM-Ubunturunner; its Docker-mounted build executes CMake and Make against PR-controlled files. Restore the fork guard here too, or move this job to an isolated hosted runner.
if: ${{ !cancelled() && (needs.build_SLES_image.result == 'success' || needs.build_SLES_image.result == 'skipped') }}
.github/workflows/ci.yaml:184
- [agent]: This condition similarly allows fork PRs into
cppcheckon the self-hostedROCM-Ubunturunner; the job mounts and executes the checked-out repository, including PR-controlled build and test scripts. Restore the fork guard here, or run this job only in an isolated environment.
if: ${{ !cancelled() && (needs.build_image.result == 'success' || needs.build_image.result == 'skipped') }}
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| github.event.pull_request.head.repo.full_name == github.repository) && | ||
| needs.check_image.outputs.imageexists != 'true' | ||
| }} | ||
| if: ${{ needs.check_image.outputs.imageexists != 'true' }} |
eddieliao
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5240