Conversation
ghedo
force-pushed
the
matmulnbit-2d-zero-points
branch
from
September 15, 2026 19:14
e6b9e48 to
a5c9992
Compare
ghedo
force-pushed
the
matmulnbit-2d-zero-points
branch
from
September 15, 2026 19:17
a5c9992 to
393ff14
Compare
The earlier scale-shape fix in commit 7eaafc3 (PR ROCm#3698) accepted multidimensional inputs but left zero point validation requiring a flattened layout. The official com.microsoft MatMulNBits specification defines packed zero points as a 2D tensor with shape [N, ceil(k_blocks * bits / 8)]. Validate packed zero points by element count so both the schema's 2D layout and legacy flattened tensors are accepted. Update the parser and verification fixtures to cover the 2D layout.
ghedo
force-pushed
the
matmulnbit-2d-zero-points
branch
from
September 17, 2026 17:44
393ff14 to
e758bad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MIGraphX's ONNX importer rejects valid
MatMulNBitsgraphs because the packed zero point tensor is validated by exact shape rather than by element count.Technical Details
The earlier scale-shape fix in commit 7eaafc3 (PR #3698) accepted multidimensional inputs but left zero point validation requiring a flattened layout.
The official com.microsoft MatMulNBits specification defines packed zero points as a 2D tensor with shape
[N, ceil(k_blocks * bits / 8)].Validate packed zero points by element count so both the schema's 2D layout and legacy flattened tensors are accepted. Update the parser and verification fixtures to cover the 2D layout.
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot ApplicableFollow the LLVM AI Tool Use Policy for contributions using AI.