Remove HIP PCH workaround - #3484
Merged
Merged
Conversation
jmmartinez
requested review from
BradPepersAMD and
BrianHarrisonAMD
as code owners
January 28, 2025 16:05
jmmartinez
force-pushed
the
dead-defines
branch
from
February 11, 2025 09:02
9c3cfa7 to
9f7f1a9
Compare
HIP PCH have been gone for a long time, the code doesn't use HIP PCH anyways.
jmmartinez
force-pushed
the
dead-defines
branch
from
February 11, 2025 09:04
9f7f1a9 to
9fcf8a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HIP PCH have been gone for a long time, and the current MIOpen code doesn't use HIP PCH anyways.
This PR removes the related workaround and defines.