Conversation
lancesix
reviewed
Sep 18, 2026
Under the rocm-generic board, generic_target_for returns "" for architectures that have no generic AMDGPU target mapping (e.g. gfx90a, which falls between the gfx9-generic and gfx9-4-generic buckets). hcc_amdgpu_targets silently dropped such architectures, so no --offload-arch flag was passed at all. Instead, fall back to using the concrete arch as the offload target and emit a warning so it's clear the generic target isn't actually being exercised for that architecture.
lumachad
force-pushed
the
users/lumachad/amd-staging/generic-fallback
branch
from
September 18, 2026 12:49
cd13915 to
ea5f15f
Compare
lumachad
marked this pull request as ready for review
September 18, 2026 12:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generic_target_forreturns""for architectures with no compatible generic AMDGPU target (e.g. gfx90a, which falls between the gfx9-generic and gfx9-4-generic buckets).hcc_amdgpu_targetssilently dropped such architectures, so no--offload-archflag was passed at all.Test plan
gdb.rocm/hcc-amdgpu-targets.expcovering mapped, unmapped (gfx90a), and mixed arch lists underrocm_use_generic_targets.gdb.rocm/hcc-amdgpu-targets.explocally.🤖 Generated with Claude Code