[TRITON] Move triton_tests into respective folders - #1602
Merged
Merged
Conversation
Boss2002n
marked this pull request as ready for review
December 10, 2025 07:18
Boss2002n
force-pushed
the
amd/satya/organise_triton_tests
branch
from
December 10, 2025 07:19
cd94594 to
6bc2875
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reorganizes the triton test files by moving them into a more structured folder hierarchy, updating all import statements to reflect the new paths.
Key Changes:
- Updated import statements across multiple test files to use absolute paths starting with
op_tests.triton_tests - Reorganized tests into categorized subdirectories (gemm/basic, gemm/fused, gemm/feed_forward, gemm/batched, quant, moe, rope)
- Changed relative imports to absolute imports for better clarity and maintainability
Reviewed changes
Copilot reviewed 13 out of 62 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| op_tests/triton_tests/test_fused_kv_cache.py | Updated imports to reference rope tests from new op_tests.triton_tests.rope path |
| op_tests/triton_tests/test_activation.py | Updated imports to reference quant and gemm tests from new nested folder structure |
| op_tests/triton_tests/rope/test_rope.py | Updated import to use absolute path for ref_rope functions |
| op_tests/triton_tests/quant/test_fused_mxfp4_quant.py | Updated imports to reference gemm and quant tests from new folder structure |
| op_tests/triton_tests/quant/test_fused_fp8_quant.py | Updated import to reference quant test from new path |
| op_tests/triton_tests/moe/test_moe_mx.py | Updated import to reference moe test from new path |
| op_tests/triton_tests/gemm/fused/test_fused_gemm_afp4wfp4_split_cat.py | Updated import to reference batched gemm test from new path |
| op_tests/triton_tests/gemm/fused/test_fused_gemm_afp4wfp4_mul_add.py | Updated imports to reference basic gemm tests from new path |
| op_tests/triton_tests/gemm/fused/test_fused_gemm_afp4wfp4_a16w16.py | Updated imports to reference basic gemm tests from new nested structure |
| op_tests/triton_tests/gemm/fused/test_fused_gemm_a8w8_blockscale_a16w16.py | Updated imports to reference basic gemm tests from new path |
| op_tests/triton_tests/gemm/feed_forward/test_ff_a16w16_fused.py | Updated imports to reference basic gemm and feed_forward utils from new paths |
| op_tests/triton_tests/gemm/feed_forward/test_ff_a16w16.py | Updated imports to reference feed_forward utils and basic gemm from new paths |
| op_tests/triton_tests/gemm/basic/test_gemm_a16w16_gated.py | Updated import to reference basic gemm test from new path |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Boss2002n
requested review from
azaidy,
brunomazzottiamd,
cagrikymk,
k50112113 and
lucas-santos-amd
December 10, 2025 13:49
Boss2002n
force-pushed
the
amd/satya/organise_triton_tests
branch
from
December 10, 2025 14:00
ce049e2 to
4724476
Compare
brunomazzottiamd
previously approved these changes
Dec 10, 2025
Boss2002n
force-pushed
the
amd/satya/organise_triton_tests
branch
2 times, most recently
from
December 11, 2025 12:20
5829565 to
e486fc7
Compare
…t suggestion Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Boss2002n
force-pushed
the
amd/satya/organise_triton_tests
branch
from
December 11, 2025 12:38
e486fc7 to
340d63f
Compare
lucas-santos-amd
approved these changes
Dec 11, 2025
lucas-santos-amd
left a comment
Contributor
There was a problem hiding this comment.
With a PR this big, it's a good idea to wait for the Triton CI to pass, even though it isn't required to merge. That aside, LGTM!
Contributor
It's really mandatory all Triton tests to pass. |
brunomazzottiamd
approved these changes
Dec 11, 2025
brunomazzottiamd
requested changes
Dec 12, 2025
brunomazzottiamd
self-requested a review
December 12, 2025 14:26
brunomazzottiamd
approved these changes
Dec 12, 2025
zhuyuhua-v
pushed a commit
that referenced
this pull request
Dec 17, 2025
* Move triton_tests into folders * fix import errors * formatting fix * remove misc folder * Update op_tests/triton_tests/quant/test_fused_mxfp4_quant.py - copilot suggestion * remove import workarounds * fix op_benchmarks imports
ZhangLirong-amd
pushed a commit
that referenced
this pull request
Dec 29, 2025
* Move triton_tests into folders * fix import errors * formatting fix * remove misc folder * Update op_tests/triton_tests/quant/test_fused_mxfp4_quant.py - copilot suggestion * remove import workarounds * fix op_benchmarks imports
valarLip
pushed a commit
that referenced
this pull request
Mar 18, 2026
* Move triton_tests into folders * fix import errors * formatting fix * remove misc folder * Update op_tests/triton_tests/quant/test_fused_mxfp4_quant.py - copilot suggestion * remove import workarounds * fix op_benchmarks imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorganize triton_tests into categorized folder structure
Restructured the triton_tests directory to improve code organization and maintainability by grouping related tests into logical categories.
Easier to run specific test categories, for example:
pytest aiter/op_tests/triton_tests/ # All tests
pytest aiter/op_tests/triton_tests/gemm/ # Just GEMM tests
pytest aiter/op_tests/triton_tests/gemm/basic/ # Just basic GEMM tests
pytest aiter/op_tests/triton_tests/moe/ # Just MOE tests
and so on