[SWDEV-318074] Fix undefined references to modulo functions in target region - #65
Merged
Merged
Conversation
… region Eliminate calls to variadic modulo runtime functions. Variadic functions cause linking errors for OpenMP target pragma if we compile code without inline optimization. OpenMP math library is used for C/C++ and Fortran code. That's why Fortran runtime functions names should not collide with user C++ function names. Adding prefix __ before Fortran runtime functions name eliminates potential conflict with user C++ function names. Co-Author: Shivarama Rao
ronlieb
approved these changes
Nov 18, 2022
Contributor
|
and merged to aomp-epsdb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate calls to variadic modulo runtime functions. Variadic functions cause linking errors for OpenMP target pragma if we compile code without inline optimization (O0 level).
OpenMP math library is used for C/C++ and Fortran code. That's why Fortran runtime functions names should not collide with user C++ function names. Adding prefix __ before Fortran runtime functions name eliminates potential conflict with user C++ function names.
Co-Author: Shivarama Rao