Handle argument mismatch in OpenMP kernel - #67
Merged
Merged
Conversation
Clang and Flang can generate the code where the host side can invoke target offloading procedure with more arguments than the number of device OpenMP kernel arguments. If given host symbol is not mapped into the device symbol then it should be not treated as valid param for offloading.
ronlieb
approved these changes
Feb 20, 2023
ronlieb
left a comment
Contributor
There was a problem hiding this comment.
LGTM, passes my tests, and most importantly passes with cov=4 and cov=5
rocm-ci
pushed a commit
that referenced
this pull request
May 1, 2023
Clang and Flang can generate the code where the host side can invoke target offloading procedure with more arguments than the number of device OpenMP kernel arguments. If given host symbol is not mapped into the device symbol then it should be not treated as valid param for offloading. Change-Id: Iba7480b08030447532522a4ad8f5a55f7dcef34d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang and Flang can generate the code where the host side can invoke target offloading procedure with more arguments than the number of device OpenMP kernel arguments.
If given host symbol is not mapped into the device symbol then it should be not treated as valid param for offloading.