[OpenMP] Fix type modification of mapped OpenMP variables - #68
Merged
ronlieb merged 1 commit intoFeb 22, 2023
Merged
Conversation
We should modify type of target param only if: * we call the function which launches offloaded kernel and: * host variable is not mapped as kernel argument
ronlieb
approved these changes
Feb 22, 2023
ronlieb
left a comment
Contributor
There was a problem hiding this comment.
tests well, thanks, approving, landing
rocm-ci
pushed a commit
that referenced
this pull request
May 1, 2023
We should modify type of target param only if: * we call the function which launches offloaded kernel and: * host variable is not mapped as kernel argument Change-Id: Ia8e51d5841d7e6d631d13457be29a43c664b1fd4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should modify type of target param only if: