Skip to content

EXSWHTEC-80 - Implement tests for hipModuleGetGlobal - #23

Closed
music-dino wants to merge 13 commits into
ROCm:developfrom
mirza-halilcevic:hipModuleGetGlobal_tests
Closed

EXSWHTEC-80 - Implement tests for hipModuleGetGlobal #23
music-dino wants to merge 13 commits into
ROCm:developfrom
mirza-halilcevic:hipModuleGetGlobal_tests

Conversation

@music-dino

@music-dino music-dino commented Dec 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Implement positive tests to check basic behavior for globals of different types
  • Implement positive and negative parameter tests.

gargrahul and others added 7 commits October 26, 2022 03:59
@gargrahul
SWDEV-355313 - Move catch tests and samples
cea96af 
Change-Id: I66f0c09e9c7405ec7430b1883e0e89542fdb87a0
@gargrahul
SWDEV-355313 - Add README
909e7e4 
Change-Id: I212b82b1b3a78a368b85ea64e338371a34b405f9
@gargrahul
SWDEV-355313 - Update amd-staging branch
094b9af 
Change-Id: Ib455f72b5be77e1a81137d15c07ea41161b16a3e
@gargrahul
SWDEV-355313 - Update README
9daa6d0 
Change-Id: Ief96e274f4143e80ceb3e40f04d38ae217777583
@gargrahul
SWDEV-355313 - Update latest code
c49043e 
Change-Id: I9c03cde09b42c8e3726153c2a177359efc8d6d29
@music-dino
Create common code for module tests
580df9d
@music-dino
EXSWHTEC-80 - Implement tests for hipModuleGetGlobal
0e719cb 
- Basic positive tests
- Negative parameter tests
@milos-mozetic milos-mozetic mentioned this pull request Dec 19, 2022
Open
chrispaquot
chrispaquot requested changes Feb 16, 2023
View reviewed changes

@chrispaquot chrispaquot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having so many #if HT_NVIDIA, can you remove them and put the tests in the json file to avoid running them?

@music-dino

music-dino commented Feb 16, 2023

Copy link
Copy Markdown
Contributor Author

Instead of having so many #if HT_NVIDIA, can you remove them and put the tests in the json file to avoid running them?

As far as I am aware, there is no way to skip individual sections via the json, only entire test cases.

@chrispaquot

chrispaquot commented Feb 22, 2023

Copy link
Copy Markdown
Contributor

Instead of having so many #if HT_NVIDIA, can you remove them and put the tests in the json file to avoid running them?

As far as I am aware, there is no way to skip individual sections via the json, only entire test cases.

@mangupta What should we do here then? Or just skip the whole test for now?

@chrispaquot

chrispaquot commented Apr 14, 2023

Copy link
Copy Markdown
Contributor

Instead of having so many #if HT_NVIDIA, can you remove them and put the tests in the json file to avoid running them?

As far as I am aware, there is no way to skip individual sections via the json, only entire test cases.

OK so instead, create new a new TEST_CASE for the failing ones.

@music-dino

music-dino commented Apr 18, 2023

Copy link
Copy Markdown
Contributor Author

Instead of having so many #if HT_NVIDIA, can you remove them and put the tests in the json file to avoid running them?

As far as I am aware, there is no way to skip individual sections via the json, only entire test cases.

OK so instead, create new a new TEST_CASE for the failing ones.

The requested change has been implemented.

@rakesroy

rakesroy commented Jul 11, 2023

Copy link
Copy Markdown
Contributor

@music-dino ,
Will you please resolve the merge conflicts in this PR?

@rakesroy

rakesroy commented Feb 26, 2024

Copy link
Copy Markdown
Contributor

PR has been merged into develop branch via commit ce7e67a.

@rakesroy rakesroy closed this Feb 26, 2024
rocm-ci pushed a commit that referenced this pull request Feb 26, 2024
@mirza-halilcevic @rakesroy
EXSWHTEC-80 - Implement tests for hipModuleGetGlobal #23
ce7e67a 
Change-Id: I873ef5c977ec252425b81e3ed7ea33c861277efb
rocm-ci pushed a commit that referenced this pull request Feb 26, 2024
@rakesroy
SWDEV-1 - Merge github PRs to amd-staging
96df1fd 
- #119
- #151
- #57
- #58
- #59
- #60
- #99
- #139
- #152
- #48
- #54
- #53
- #24
- #23
- #22
- #21
- #20
- #14
- #8

Change-Id: I1eea54cd1436f3ddbfd5c1b3b2f672eb81d03cd4
jayhawk-commits pushed a commit to ROCm/rocm-systems that referenced this pull request Aug 18, 2025
@rakesroy
SWDEV-1 - Merge github PRs to amd-staging
fa871e2 
- ROCm/hip-tests#119
- ROCm/hip-tests#151
- ROCm/hip-tests#57
- ROCm/hip-tests#58
- ROCm/hip-tests#59
- ROCm/hip-tests#60
- ROCm/hip-tests#99
- ROCm/hip-tests#139
- ROCm/hip-tests#152
- ROCm/hip-tests#48
- ROCm/hip-tests#54
- ROCm/hip-tests#53
- ROCm/hip-tests#24
- ROCm/hip-tests#23
- ROCm/hip-tests#22
- ROCm/hip-tests#21
- ROCm/hip-tests#20
- ROCm/hip-tests#14
- ROCm/hip-tests#8

Change-Id: I1eea54cd1436f3ddbfd5c1b3b2f672eb81d03cd4


[ROCm/hip-tests commit: 96df1fd]
ammallya pushed a commit that referenced this pull request Oct 28, 2025
@mirza-halilcevic @rakesroy
EXSWHTEC-80 - Implement tests for hipModuleGetGlobal #23
578ddd1 
Change-Id: I873ef5c977ec252425b81e3ed7ea33c861277efb


[ROCm/hip-tests commit: ce7e67a]
ammallya pushed a commit that referenced this pull request Oct 28, 2025
@rakesroy
SWDEV-1 - Merge github PRs to amd-staging
abf09e1 
- #119
- #151
- #57
- #58
- #59
- #60
- #99
- #139
- #152
- #48
- #54
- #53
- #24
- #23
- #22
- #21
- #20
- #14
- #8

Change-Id: I1eea54cd1436f3ddbfd5c1b3b2f672eb81d03cd4


[ROCm/hip-tests commit: 96df1fd]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrispaquot chrispaquot chrispaquot requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@music-dino @chrispaquot @rakesroy @gargrahul @milos-mozetic @mirza-halilcevic