Conversation
Signed-off-by: jhchouuu <jiahzhou@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #625 for two nodes of 8×MI308X with dual-port 200Gbps Thor2 NICs (EP16).
The internode tuner used the first search candidate as its reference when a shape missed the tuning table. The DeepSeek shapes in this study all miss that table, so those comparisons did not measure improvement over the actual default. Resolve the reference geometry from the constructed op, including dtype and explicit overrides.
This change adds:
--cmd comparefollows the paired test with ordinary benchmarks that keep only one op alive.Profiles require an exact measured shape/capacity and explicit selection. The global tuning lookup and
autothreshold are unchanged.Measurement provenance
The full matrix was measured on
62ee2674with the documented minimal BNXT completion patch, applied equally to reference and candidate. #653 has since merged; this branch is rebased ontoceac6df6and takes the transport fix from main. The patch file is historical provenance, not a new transport code change. The complete performance matrix was not rerun on the new base.The benchmark uses eager HIP event regions, excludes expert computation, and reports the FP8→BF16 conversion interval separately. Capacity equals live token count. The profiles are specific to the recorded hardware, software and network setup.
Validation
git diff --checkpassed.