Skip to content

[SOW MS3] Workaround MIOPEN output tensor memory format (NDHWC) issue - #1072

Merged
jithunnair-amd merged 15 commits into
sow_ms3from
sow_ms3_conv_disable_miopen_pr
Sep 14, 2022
Merged

jithunnair-amd merged 15 commits into
sow_ms3from
sow_ms3_conv_disable_miopen_pr

Conversation

@micmelesse

@micmelesse micmelesse commented Aug 8, 2022

Copy link
Copy Markdown

added a fix for these tests and enable them

python test_nn.py --verbose  TestNNDeviceTypeCUDA.test_conv_cudnn_ndhwc_cuda_float16
python test_nn.py --verbose  TestNNDeviceTypeCUDA.test_conv_cudnn_ndhwc_cuda_float32

@jithunnair-amd

Copy link
Copy Markdown
Collaborator

retest this please

@pruthvistony pruthvistony changed the title Sow ms3 conv disable miopen pr [SOW MS3] conv disable miopen pr Aug 11, 2022
@jithunnair-amd

jithunnair-amd commented Aug 15, 2022

Copy link
Copy Markdown
Collaborator

@micmelesse Tests failed in CI: http://rocmhead.amd.com:8080/job/pytorch/job/pytorch-test-1/235/consoleText

Aug 15 05:56:09   test_conv_cudnn_ndhwc_cuda_float16 (__main__.TestNNDeviceTypeCUDA) ... _convolution
Aug 15 05:56:09 select_conv_backend
Aug 15 05:56:09 _convolution
Aug 15 05:56:09 select_conv_backend
Aug 15 05:56:09 select_conv_backend
Aug 15 05:56:09 select_conv_backend
Aug 15 05:56:09 FAIL (0.010s)
Aug 15 05:56:09   test_conv_cudnn_ndhwc_cuda_float32 (__main__.TestNNDeviceTypeCUDA) ... _convolution
Aug 15 05:56:09 select_conv_backend
Aug 15 05:56:09 _convolution
Aug 15 05:56:09 select_conv_backend
Aug 15 05:56:09 select_conv_backend
Aug 15 05:56:09 select_conv_backend
Aug 15 05:56:09 FAIL (0.006s)
...
Aug 15 05:56:13   test_convert_conv2d_weight_memory_format_cuda (__main__.TestNNDeviceTypeCUDA) ... _convolution
Aug 15 05:56:13 select_conv_backend
Aug 15 05:56:13 miopen_convolution
Aug 15 05:56:13 FAIL (0.120s)

@jithunnair-amd

Copy link
Copy Markdown
Collaborator

@micmelesse Any progress on this PR?

@micmelesse

Copy link
Copy Markdown
Author

@jithunnair-amd I am still working on it. Just disabling MIOPEN doesnot work. I am looking at another solution.

@jithunnair-amd
jithunnair-amd marked this pull request as draft August 30, 2022 19:43
@micmelesse micmelesse changed the title [SOW MS3] conv disable miopen pr [SOW MS3] Workaround MIOPEN output tensor issue Sep 9, 2022
@micmelesse micmelesse changed the title [SOW MS3] Workaround MIOPEN output tensor issue [SOW MS3] Workaround MIOPEN output tensor memory format (NDHWC) issue Sep 9, 2022
@micmelesse

micmelesse commented Sep 12, 2022

Copy link
Copy Markdown
Author

@jithunnair-amd Two of the tests pass. The failures donot seem related to my changes. The failures are in different files. The distributed test fails due to a docker error.

@micmelesse
micmelesse marked this pull request as ready for review September 12, 2022 21:13
@micmelesse

micmelesse commented Sep 12, 2022

Copy link
Copy Markdown
Author

I will do a seperate pr for the third test

@jithunnair-amd jithunnair-amd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just want another review to confirm that this would be in line with how we can fix unit tests for sow ms3 branch.

@jithunnair-amd
jithunnair-amd merged commit 116e0e7 into sow_ms3 Sep 14, 2022
BLOrange-AMD pushed a commit that referenced this pull request Oct 14, 2022
…#1072)

* add scripts

* default nightly pytorch

* update scripts

* disable miopen path for channel last

* add new docker image

* add CONTAINER_ID

* remove scripts

* enable tests

* update conv script

* don't use MIOPEN

* limit to 2 of the passing  tests

* only apply when Miopen is invoked
@micmelesse
micmelesse deleted the sow_ms3_conv_disable_miopen_pr branch May 2, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants