[SOW MS3] Workaround MIOPEN output tensor memory format (NDHWC) issue - #1072
Merged
Merged
Conversation
Collaborator
|
retest this please |
Collaborator
|
@micmelesse Tests failed in CI: http://rocmhead.amd.com:8080/job/pytorch/job/pytorch-test-1/235/consoleText |
Collaborator
|
@micmelesse Any progress on this PR? |
Author
|
@jithunnair-amd I am still working on it. Just disabling MIOPEN doesnot work. I am looking at another solution. |
jithunnair-amd
marked this pull request as draft
August 30, 2022 19:43
Author
|
@jithunnair-amd Two of the tests pass. The failures donot seem related to my changes. The failures are in different files. The distributed test fails due to a docker error. |
micmelesse
marked this pull request as ready for review
September 12, 2022 21:13
Author
|
I will do a seperate pr for the third test |
jithunnair-amd
approved these changes
Sep 13, 2022
jithunnair-amd
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, just want another review to confirm that this would be in line with how we can fix unit tests for sow ms3 branch.
jeffdaily
approved these changes
Sep 14, 2022
BLOrange-AMD
pushed a commit
that referenced
this pull request
Oct 14, 2022
…#1072) * add scripts * default nightly pytorch * update scripts * disable miopen path for channel last * add new docker image * add CONTAINER_ID * remove scripts * enable tests * update conv script * don't use MIOPEN * limit to 2 of the passing tests * only apply when Miopen is invoked
akashveramd
pushed a commit
that referenced
this pull request
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a fix for these tests and enable them