skip test_baddbmm_cuda_* for ROCm for release/1.13 - #1371
Merged
dnikolaev-amd merged 1 commit intoMar 19, 2024
Merged
dnikolaev-amd merged 1 commit into
dnikolaev-amd merged 1 commit into
Conversation
pruthvistony
approved these changes
Mar 19, 2024
pruthvistony
left a comment
Collaborator
There was a problem hiding this comment.
Skipping the UT is OK for release/1.13 branch, since we dont want to spend more time on cherry-picking all the changes from newer branches into this old release/1.13 branch.
dnikolaev-amd
marked this pull request as ready for review
March 19, 2024 18:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release/1.13 is very old to fix, just skip test for ROCm
newer versions were fixed by this PR #1283