Conversation
The overlap test emulates compute and communication with fixed-cycle GPU sleeps. DVFS and device contention can change their wall-clock duration between separate single-shot measurements, causing false failures under load. Interleave reference and test measurements and compare their least-perturbed samples. This only improves timing stability; it does not relax assertions or tolerances, change emulated sleep durations, or add conditional retries or skips. Test Plan: ``` python -m pytest test/distributed/_composable/fsdp/test_fully_shard_overlap.py::TestFullyShardOverlap::test_fully_shard_training_overlap ``` Disappeared timing assertion flakiness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The overlap test emulates compute and communication with fixed-cycle GPU sleeps. DVFS and device contention can change their wall-clock duration between separate single-shot measurements, causing false failures under load.
Interleave reference and test measurements and compare their least-perturbed samples. This only improves timing stability; it does not relax assertions or tolerances, change emulated sleep durations, or add conditional retries or skips.
Test Plan:
Disappeared timing assertion flakiness
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist