Conversation
…ytorch#194100) Check the return values of AOTriton forward and backward attention calls with `AT_CUDA_CHECK`. AOTriton returns a `hipError_t`, but the existing code stores it in a local variable and never checks it. A synchronous launch failure can therefore appear successful at the originating operation and surface during a later, unrelated HIP call. This makes failures difficult to diagnose and can incorrectly attribute them to subsequent operations. Add immediate error checking to all AOTriton attention callsites: - Forward attention - Variable-length forward attention - Backward attention - Variable-length backward attention Launch failures are now reported at the operation that caused them using PyTorch’s standard accelerator error handling. - Source lint checks passed. - `git diff --check` passed. - Verified that all four AOTriton forward/backward callsites are checked and no ignored `hipError_t` variables remain. Pull Request resolved: pytorch#194100 Approved by: https://github.com/xinyazhang, https://github.com/jeffdaily (cherry picked from commit 875d815)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of upstream PR pytorch#194100 for the release/2.11 branch.