Conversation
Match the current CUDA 13.2 and Noble ROCm Python 3.11 trunk jobs so parity selects the full push run instead of a scheduled periodic run.
Use the configured distributed fallback for baseline commits just as the current-commit path does, preserving its workflow-specific log prefix.
| error_msg=f"Baseline distributed fallback not found for {baseline_sha}", | ||
| ) | ||
|
|
||
| print(f"Baseline distributed workflow '{baseline_dist_workflow}' id: {baseline_dist_wf['id']}") |
There was a problem hiding this comment.
If baseline_dist_wf is None and arch is not in baseline_dist_fallbacks, will baseline_dist_wf not stay None and error here in baseline_dist_wf['id']?
|
Also, And while you're cleaning up fallbacks, the fallbacks for mi200 should be removed too: |
Problem
Commit-vs-commit parity only applies configured workflow fallbacks to the current commit. If the baseline lacks the primary distributed workflow, the exception is downgraded to a warning and the report incorrectly shows zero baseline distributed tests even when the fallback workflow contains them.
Run
35114338058showed this asymmetry:b285e55aused the MI350 trunk fallback and reported 5,172 tests, while58acd33breported zero despite all three distributed shards existing in its trunk run.Tracked in AIPYTORCH-1223. Stacked on #3650.
Changes
Apply the configured distributed fallback to baseline downloads and carry its workflow-specific job prefix into baseline log collection.
Validation
python -m py_compile download_testlogsb285e55avs58acd33b): https://github.com/ethanwee1/pytorch/actions/runs/35143014866Both workflows passed. The personal-fork report contains 5,172 distributed tests and 369,710 total tests on each commit, with 100% overall agreement and zero failed tests. Source logs were disabled to isolate artifact collection from the historical job-name change handled by the next stacked PR.