Skip to content

Image picker support - #31

Open
RSully wants to merge 8 commits into
masterfrom
feature-image_picker
Open

Image picker support#31
RSully wants to merge 8 commits into
masterfrom
feature-image_picker

Conversation

@RSully

@RSullyRSully commented Aug 24, 2013

Copy link
Copy Markdown
Owner

This branch is a testing ground for adding custom-image support as suggested in #29.

RSully
RSully reviewed Aug 25, 2013
View reviewed changes
Comment threadRSColorPicker/ColorPickerClasses/RSColorPickerView.m

@RSullyRSullyAug 25, 2013

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be in the background

@RSully
Merge branch 'master' into feature-image_picker
462950f
Conflicts:
RSColorPicker/ColorPickerClasses/RSColorPickerView.h
RSColorPicker/ColorPickerClasses/RSColorPickerView.m
RSColorPicker/TestColorViewController.m
@RSully

RSully commented Jan 18, 2014

Copy link
Copy Markdown
OwnerAuthor

This is pretty broken right now given the "state" concept we implemented.

@dsmurfin

dsmurfin commented Jan 20, 2014

Copy link
Copy Markdown

I can see why the new state stuff has broken this now I've had a look through the code. I reckon this would be quite a useful addition if it can be made to work with the new code.

@RSully

RSully commented Jan 20, 2014

Copy link
Copy Markdown
OwnerAuthor

Yeah I haven't lost hope for this yet.

A few solutions come to mind:

  • New state stuff just has to go
  • Heavy refactoring with if/else for state vs image.
  • State could be refactored into different state types:
    • HSV state
    • Live state (used for custom images, and useful for debugging)

/ping @unixpickle

@dsmurfin

dsmurfin commented Jan 20, 2014

Copy link
Copy Markdown

I guess the cleanest option is potentially no.3. That keeps the logic in the same class etc and should result in less changes to RSColorPickerView

@unixpickle

unixpickle commented Jan 20, 2014

Copy link
Copy Markdown
Contributor

If we made a state base class and then subclassed it for HSV and Live states that would possibly work. I'll look into it when I'm free.

@RSully

RSully commented Jan 21, 2014

Copy link
Copy Markdown
OwnerAuthor

Even an interface/protocol might do the job. Edit: abstract/base class is probably better, as suggested.

@RSullyRSully mentioned this pull request Dec 31, 2014
Closed
@RSullyRSully mentioned this pull request Jan 20, 2015
Closed
@RSullyRSully mentioned this pull request Jul 16, 2015
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RSully@dsmurfin@unixpickle