Skip to content

Bump minimal php requirement to 7.3 - #224

Merged
RWOverdijk merged 2 commits into
RWOverdijk:masterfrom
legow:bump-php-to-7-3
Nov 5, 2020
Merged

Bump minimal php requirement to 7.3#224
RWOverdijk merged 2 commits into
RWOverdijk:masterfrom
legow:bump-php-to-7-3

Conversation

@adamturcsan

Copy link
Copy Markdown
Contributor

Used dependency (ie. laminas/laminas-dependency-plugin) already requires this

Used dependency (ie. laminas/laminas-dependency-plugin) already requires this
@adamturcsan

adamturcsan commented Nov 4, 2020

Copy link
Copy Markdown
ContributorAuthor

If there's anything else that needs to be changed for php:^7.3 I'll try to follow.

There are quite old dependencies that could be updated also if php7.2 support is not required. I'll look into it, if necessary, but honestly I just want to push for a release to use this with up-to-date environment ASAP.

@adamturcsan

Copy link
Copy Markdown
ContributorAuthor

Ok, so it didn't caught my attention that the 2.1.0 tag was already made(packagist crawler hasn't noticed it either), so now I could use the lib if packagist notices 👍
But the CI is still failing, the php:^7.2 requirement is still false, so here it is :)

@RWOverdijk

Copy link
Copy Markdown
Owner

You're right, that was messy of me. Thanks for this.

@adamturcsan

Copy link
Copy Markdown
ContributorAuthor

Ehm, could you tell me, why haven't you merged this?
2.1.0...2.1.1 It shows no changes :( I assume the CI will also fail (it recieved a job for 7.2)

@RWOverdijkRWOverdijk reopened this Nov 5, 2020
@RWOverdijk
RWOverdijk merged commit 3f6dc69 into RWOverdijk:masterNov 5, 2020
@RWOverdijk

Copy link
Copy Markdown
Owner

I thought I did hit merge... Chaotic day.

@adamturcsan

Copy link
Copy Markdown
ContributorAuthor

The point is we sorted it out. Thank you! :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@adamturcsan@RWOverdijk