Modify run_after_commit to accept blocks

[tism]

Patch to run_after_commit so it accepts blocks in place of a method

[zbelzer]

Ah yes, it's already bound because it's an argument. I remember now. Thanks.

[Gurpartap]

Can you also add encoding to the gemspec, since there's a unicode only character in the author name 😄? That way I can point my Gemfile to your repo (without encoding issues, which cause an error otherwise). Update: This is apparently an issue with the parent repo itself. Sorry for posting here.

[Gurpartap]

There's an even sweeter way to utilize the proposed pull request:

after_transition :stopped => :starting do |server|
server.run_after_commit do
ServerWorker::Start.perform_async(server.id) # assuming sidekiq based worker
end
end

You'll need to add the following to the model though, too, to make the run_after_commit method accessible in state_machine block:

def run_after_commit
super
end

[wijet]

@tism Hey, could you please add this new block syntax to the README? Otherwise your pull request looks good. Thank you.

@Gurpartap There is utf-8 encoding in the gemspec already. It seems to work, because when I remove it, I get encoding error.

[Gurpartap]

@wijet when I try bundle install with gem 'after_commit_queue', :git => 'git://github.com/C3/after_commit_queue.git' (or your repo) in the Gemfile, I get encoding errors. Can you try reproducing so I could know if it's only me?

I got around the problem with this in my Gemfile.

if RUBY_VERSION =~ /1.9/
Encoding.default_external = Encoding::UTF_8
Encoding.default_internal = Encoding::UTF_8
end

But of course, I'm looking to not needing to specify that in the Gemfile.

[wijet]

@Gurpartap I cannot reproduce it, the way you shown it. Could you please paste the error?
And also, can you clone the after_commit_queue and run bundle install on it? What is your $LC_ALL and $LANG settings?

[Gurpartap]

I guess it's those variables. Mine are not set to anything (intentionally). Can you try without those? (OS X, which most of us use, doesn't ship with those variables by default, afaik)

[Gurpartap]

Here's the error

ArgumentError: invalid byte sequence in US-ASCII
An error occured while installing after_commit_queue (0.0.2), and Bundler cannot continue.
Make sure that `gem install after_commit_queue -v '0.0.2'` succeeds before bundling.

MRI ruby defaults to US-ASCII, iirc.

[wijet]

I've extracted this problem to #3