Skip to content

Adds tests for the controlsClass and renames some variables - #52

Merged
StephenNneji merged 2 commits into
RascalSoftware:masterfrom
StephenNneji:controldef_class_tests
Mar 3, 2023
Merged

Adds tests for the controlsClass and renames some variables#52
StephenNneji merged 2 commits into
RascalSoftware:masterfrom
StephenNneji:controldef_class_tests

Conversation

@StephenNneji

@StephenNnejiStephenNneji commented Feb 1, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Adds tests for the controls class
Refactors controlDef.calcSldDuringFit to use boolean
Adds type check for controlDef.resamPar

@StephenNnejiStephenNneji mentioned this pull request Feb 1, 2023
Closed
42 tasks
@StephenNneji
StephenNnejiforce-pushed the controldef_class_tests branch from 4491b59 to 3467c62CompareMarch 2, 2023 15:02
@StephenNneji
StephenNnejiforce-pushed the controldef_class_tests branch from 3467c62 to 8231267CompareMarch 2, 2023 15:51
@StephenNnejiStephenNneji changed the title Adds tests and improves docs for the controlDef class Adds tests for the controlsClass and renames some variablesMar 2, 2023
@StephenNneji
StephenNneji marked this pull request as ready for review March 2, 2023 15:53
DrPaulSharp
DrPaulSharp approved these changes Mar 2, 2023
View reviewed changes
Comment threadAPI/controlsClass/controlsClass.m Outdated
Comment threadAPI/controlsClass/controlsClass.m Outdated
Comment threadAPI/controlsClass/controlsClass.m Outdated
Comment threadAPI/controlsClass/controlsClass.m Outdated
Comment threadAPI/controlsClass/controlsClass.m Outdated
Comment threadAPI/controlsClass/controlsClass.m Outdated
Comment threadAPI/controlsClass/controlsClass.m Outdated
Comment threadAPI/controlsClass/controlsClass.m
Comment threadtests/testControlsClass.m Outdated
@DrPaulSharpDrPaulSharp mentioned this pull request Mar 3, 2023
Closed
13 tasks
DrPaulSharp
DrPaulSharp approved these changes Mar 3, 2023
View reviewed changes
Comment threadutilities/validateNumber.m
@StephenNneji
StephenNnejiforce-pushed the controldef_class_tests branch from c428557 to f2a7c2eCompareMarch 3, 2023 12:53
@StephenNneji
StephenNneji merged commit 69e5a01 into RascalSoftware:masterMar 3, 2023
@StephenNneji
StephenNneji deleted the controldef_class_tests branch April 12, 2023 15:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrPaulSharpDrPaulSharpDrPaulSharp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StephenNneji@DrPaulSharp