Added tests and docs to custom file class by DrPaulSharp · Pull Request #59 · RascalSoftware/RAT

DrPaulSharp · 2023-02-10T14:52:07Z

Adds the class "testCustomFileClass" which sets out a suite of explicit tests for the custom file class within project class.
Adds custom RAT exceptions to utilities/exceptions and implements them in "customFileClass.m"
Tests for custom exceptions included in "testExceptions"

… get routine "get.fileCount()"

…ialiseParameters" corrected to "numParams"

…iseCustomFileClassOneRow". Also removed code setting dependent property "fileCount"

…ss.m"

…Invalid"

…ewParams". Also added identifiers to error messages in "customFileClass" for testing.

…omFileClass" and removed redundant routine "getCustomNames"

…licate names are matched correctly

…n "projectClass"

…ileObjectEmpty"

…CustomName", and "setFileName" in "customFileClass"

… array "fileList" in routine "toStruct"

… MException for repeated errors.

…validType"

…invalidNumberOfInputs.m", "nameNotRecognised.m", "invalidInput.m", "invalidOption.m"

…upport for the language "Octave" from "customFileClass.m".

…ustomFile" for the initial row of the table.

…ectClass.m", alongside tests.

StephenNneji · 2023-02-14T15:13:23Z

@@ -0,0 +1,10 @@
+classdef invalidInput < MException


What is the difference btw invalid type and invalid input?

As I was developing the exceptions Invalid input split into invalid type and invalid number of inputs. I'll remove this one and we can always readd it later if needs be.

…ptions

…mFileClass.m"

StephenNneji · 2023-02-14T15:19:26Z

- initialTypesCount = 1;
- initialTypesAutoNameCounter = 1;
- initialTypesAutoNameString = 'Row';
+ exampleTable % Example Multi-Type Table for testing


I don't think there is any benefit to semicolon but its used in some classes so we have to agree a style an unify all

I'd spotted this as well. I'll take the semicolons out, which I prefer.

…ss.m"

DrPaulSharp added 24 commits February 9, 2023 14:40

Set private and dependent properties in "customFileClass.m" and added…
c8fcc24
… get routine "get.fileCount()"

BUG FIX in "testLayersClass.m" setting of property "numRows" in "init…
e57ae79
…ialiseParameters" corrected to "numParams"

Added new test code "testCustomFileClass.m"
12cf049

Added new tests "testInitialiseCustomFileClassEmpty" and "testInitial…
4f45f85
…iseCustomFileClassOneRow". Also removed code setting dependent property "fileCount"

Refactored initialisation routine in "customFileClass.m"
54125c0

Added test "testAddFile"
4150212

Added test "testAddFileInvalid"
5349bae

Refactorewd call to "addFile" in "customFileClass.m" from "projectCla…
2c0b937
…ss.m"

Added test case to "testAddFileInvalid"
6b5a6b9

Added new test "testSetCustomFile" and new test cases to "testAddFile…
4834a15
…Invalid"

Added new tests "testSetCustomFileInvalid" and "testSetCustomFileTooF…
e0140fb
…ewParams". Also added identifiers to error messages in "customFileClass" for testing.

Added new test "testSetCustomFileInvalidType"
279c773

Renamed and added new test cases to testSetCustomFileInvalidInput"
a8e7c3b

Added second example custom file to test data. also rerfactored "cust…
1793314
…omFileClass" and removed redundant routine "getCustomNames"

BUG FIX in "customFileClass.setCustomName" - used any() to ensure dup…
3a529a4
…licate names are matched correctly

Restored routine "getCustomNames" in "customFileClass" due to calls i…
0f91815
…n "projectClass"

Added new tests "testDisplayCustomFileObject" and "testDisplayCustomF…
e0a0250
…ileObjectEmpty"

Added new test "testDisplayCustomFileObjectEmptyRow"
0f795c9

Added tests "testToStruct", "testToStructEmpty", and "testToStructPwd"
dd478ce

Added test "testDisplayCustomFileObjectLongPath"
49016aa

Protected access to methods "appendNewRow", "setCustomLanguage", "set…
b5e1175
…CustomName", and "setFileName" in "customFileClass"

Added docs to "customFileClass.m"
b1b823d

Preallocated array in "customFileClass.toStruct" to aid performance
24dfd85

Tidied up test class "testCustomFileClass.m"
6031cda

DrPaulSharp requested a review from StephenNneji February 10, 2023 14:52

DrPaulSharp added 5 commits February 10, 2023 15:36

BUG FIX in "customFileClass.m" -- corrected shape of initialised cell…
89845b7
… array "fileList" in routine "toStruct"

Changed format of error identifiers in "customFileClass.m". Also used…
67f5d48
… MException for repeated errors.

Added new exception class "invalidType.m"
6ab6f95

Implemented one example of an InvalidTypeexception in "customFileClass"
cade396

Added arguments block for validation and default error message to "in…
30d156e
…validType"

DrPaulSharp added 11 commits February 13, 2023 13:33

Added new custom exceptions "duplicateName.m", "indexOutOfRange.m", "…
2cc14a4
…invalidNumberOfInputs.m", "nameNotRecognised.m", "invalidInput.m", "invalidOption.m"

Created custom exceptions in RAT/utilities/exceptions
0a7ad8f

Implemented custom exceptions in "customFileClass.m"
100e92f

Tidied code and added test suite "testExceptions.m"
0d05eea

Parameterised "testExceptions" for two different exceptions
8b3c308

Parameterised all custom exceptions in "testExceptions.m"
8beaf31

Removed redundant routines "setDataRange" and "parseDataInput", and s…
1b306bd
…upport for the language "Octave" from "customFileClass.m".

Renamed "addFile" as "addCustomFile" in "testCustomFileClass.m".
84768a0

Refactored initialisation routine in "customFileClass.m" to use "addC…
a7fb0a0
…ustomFile" for the initial row of the table.

Removed duplicate hecks from protected routines in "customFileClass.m"
a178056

Added new routine "removeCustomFile" to "customFileClass.m" and "proj…
e766156
…ectClass.m", alongside tests.

StephenNneji reviewed Feb 14, 2023
View reviewed changes

Comment threadAPI/projectClass/customFileClass.m Outdated
Comment threadtests/testCustomFileClass.m Outdated
Comment threadtests/testCustomFileClass.m Outdated
Comment threadAPI/projectClass/customFileClass.m Outdated

StephenNneji reviewed Feb 14, 2023
View reviewed changes

DrPaulSharp added 2 commits February 14, 2023 15:16

Added error identifiers as constant, hidden properties in custom exce…
7d8eff7
…ptions

Implemented use of custom exception error ID properties in "testCusto…
0f53420
…mFileClass.m"

StephenNneji reviewed Feb 14, 2023
View reviewed changes

DrPaulSharp added 5 commits February 14, 2023 15:29

Removed unused custom exception "invalidInput.m"
b66fe63

Added appropriate property attributes to properties in "customFileCla…
d736978
…ss.m"

Refactored "testExceptions.m"
ab7a0fc

Been on a semicolon hunt (in property declarations)
ff1b7c2

Merge branch 'master' into test_custom_file
6f9ceef

StephenNneji approved these changes Feb 14, 2023
View reviewed changes

DrPaulSharp merged commit 58a817c into RascalSoftware:masterFeb 14, 2023

DrPaulSharp deleted the test_custom_file branch February 14, 2023 15:46

This was referenced Feb 14, 2023
Implement custom exceptions #69
Closed
Improve RAT Testing Coverage #32
Closed

Navigation Menu

Uh oh!

Added tests and docs to custom file class - #59

Added tests and docs to custom file class#59
DrPaulSharp merged 47 commits into
RascalSoftware:masterfrom
DrPaulSharp:test_custom_file

DrPaulSharp commented Feb 10, 2023•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StephenNnejiFeb 14, 2023•
edited
Loading

Uh oh!

DrPaulSharpFeb 14, 2023

Uh oh!

StephenNnejiFeb 14, 2023•
edited
Loading

Uh oh!

DrPaulSharpFeb 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

DrPaulSharp commented Feb 10, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StephenNnejiFeb 14, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DrPaulSharpFeb 14, 2023

Choose a reason for hiding this comment

Uh oh!

StephenNnejiFeb 14, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DrPaulSharpFeb 14, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

DrPaulSharp commented Feb 10, 2023•
edited
Loading

StephenNnejiFeb 14, 2023•
edited
Loading

StephenNnejiFeb 14, 2023•
edited
Loading