Uh oh!
There was an error while loading. Please reload this page.
added the controlsClass - #10
Conversation
DrPaulSharp
left a comment
There was a problem hiding this comment.
This looks good and should do the job well. I think though that we should look to implement the procedure classes in pydantic - we will get all of the same functionality and save a LOT of lines of code. You can see how it works in "RAT/models.py"
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
edf088d to
01d29deCompare
DrPaulSharp
left a comment
There was a problem hiding this comment.
You've done a great job of using pydantic here, and it definitely makes for some cleaner code. Have a look at the comments here, and one they're sorted I'll have a closer look at the tests.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
DrPaulSharp
left a comment
There was a problem hiding this comment.
This looks great, well done. Just a couple of minor points to address and then we're there!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This reverts commit 6f329ed.
Task List
ParallelOptionsProceduresDisplayOptionsBoundHandlingOptionsStrategyOptionsBaseProcedurewith following properties:- parallel
- calcSldDuringFit
- resamPars
- display
Calculatewith following properties:- procedure
Simplexwith following properties:- procedure
- tolX
- tolFun
- maxFunEvals
- maxIter
- updateFreq
- updatePlotFreq
DEwith following properties:- procedure
- populationSize
- fWeight
- crossoverProbability
- strategy
- targetValue
- numGenerations
NSwith following properties:- procedure
- Nlive
- Nmcmc
- propScale
- nsTolerance
Dreamwith following properties:- procedure
- nSamples
- nChains
- jumpProb originally named
lambdain MATLAB- pUnitGamma
- boundHandling
ControlsClass.__repr__method.What kind of change does this PR introduce ?
What is the current behaviour ?
pythonversion of RAT lacked thecontrolClass. ClosesAdd thecontrolsClass#7What is the new behaviour ?
ControlsClassin the python version of RAT which allows users to define the calculation settings.Does this PR introduce a breaking change ?
lambdavariable from MATLAB class is renamed in python version tojumpProb.NoneinboundHandlingOptionsenum from MATLAB is renamed in python version tooff.Other Information
setProceduremethod from the MATLAB class is dropped in the python version.Usage
Create
ControlsClassby passing procedure. If no procedure is provided then it is set toProcedures.Calculate.Properties can be updated individually after
ControlsClassis created.Properties can also be set when
ControlsClassis created by passing**kwargs.