Skip to content

Adds some docstring to pybind function and some refactors - #133

Merged
StephenNneji merged 2 commits into
RascalSoftware:mainfrom
StephenNneji:add_pybind_docs
Feb 24, 2025
Merged

Adds some docstring to pybind function and some refactors#133
StephenNneji merged 2 commits into
RascalSoftware:mainfrom
StephenNneji:add_pybind_docs

Conversation

@StephenNneji

@StephenNnejiStephenNneji commented Feb 18, 2025

Copy link
Copy Markdown
Contributor

Closes#129

@StephenNneji
StephenNnejiforce-pushed the add_pybind_docs branch 2 times, most recently from 71c4e96 to 2926195CompareFebruary 18, 2025 16:16
alexhroom
alexhroom reviewed Feb 18, 2025
View reviewed changes
Comment threadcpp/includes/defines.h Outdated
alexhroom
alexhroom requested changes Feb 19, 2025
View reviewed changes

@alexhroomalexhroom left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks mostly there, just a few things to clarify

Comment threadcpp/includes/defines.h
Comment threadcpp/includes/defines.h Outdated
Comment threadcpp/includes/defines.h Outdated
Comment threadcpp/includes/defines.h Outdated
Comment threadcpp/rat.cpp Outdated
Comment threadcpp/rat.cpp Outdated
Comment threadMANIFEST.in Outdated
Comment threadcpp/includes/defines.h Outdated
Comment threadcpp/includes/defines.h Outdated
Comment threadcpp/includes/defines.h Outdated
alexhroom
alexhroom approved these changes Feb 24, 2025
View reviewed changes

@alexhroomalexhroom left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good apart from a typo!

Comment threadcpp/includes/defines.h Outdated
@StephenNneji@alexhroom
Update cpp/includes/defines.h
fd0d260
Co-authored-by: Alex H. Room <69592136+alexhroom@users.noreply.github.com>
@StephenNneji
StephenNneji merged commit 0bd4fad into RascalSoftware:mainFeb 24, 2025
@StephenNneji
StephenNneji deleted the add_pybind_docs branch September 3, 2025 13:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexhroomalexhroomalexhroom approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add docstring to the pybind11 C++ classes

2 participants

@StephenNneji@alexhroom