Skip to content

Adds additional validators and "write_script" routine - #15

Merged
DrPaulSharp merged 9 commits into
RascalSoftware:mainfrom
DrPaulSharp:extras
Oct 24, 2023
Merged

Adds additional validators and "write_script" routine#15
DrPaulSharp merged 9 commits into
RascalSoftware:mainfrom
DrPaulSharp:extras

Conversation

@DrPaulSharp

@DrPaulSharpDrPaulSharp commented Oct 17, 2023

Copy link
Copy Markdown
Collaborator

No description provided.

DrPaulSharp
DrPaulSharp commented Oct 17, 2023
View reviewed changes
Comment threadtests/test_project.py
StephenNneji
StephenNneji approved these changes Oct 18, 2023
View reviewed changes
Comment threadRAT/models.py Outdated
Comment threadRAT/models.py Outdated
Comment threadRAT/project.py Outdated
Comment threadRAT/project.py
Comment threadRAT/project.py Outdated
Comment threadtests/test_project.py Outdated
Comment threadtests/test_project.py
StephenNneji
StephenNneji reviewed Oct 23, 2023
View reviewed changes
Comment threadtests/test_project.py Outdated
])
def test_write_script(test_project, test_project_script, input_filename: str) -> None:
"""Test the script we write to regenerate the project is created and runs as expected."""
path = tempfile.mkdtemp(dir='.')

@StephenNnejiStephenNnejiOct 23, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the dir is necessary as this will create the test folder in my repo folder which will not be deleted if the test failed, without dir it should be created in the user's tmp directory. Also it will be better to setup shutil.rmtree in a teardown function

@DrPaulSharpDrPaulSharpOct 23, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, now done. Although avoiding all of this was why I had a mock file in the first place.

@DrPaulSharp
DrPaulSharp merged commit bbfebd4 into RascalSoftware:mainOct 24, 2023
@DrPaulSharp
DrPaulSharp deleted the extras branch October 24, 2023 09:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephenNnejiStephenNnejiStephenNneji approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DrPaulSharp@StephenNneji