Make "right click" change the focus to the thing that was right-clicked on

[maribethb]

Check for duplicates

• I have searched for similar issues before opening a new one.

Problem

No response

Request

When a block is right-clicked, for example, it should receive active focus regardless of whatever was previously focused. This needs to happen before we call the generate context menu code.

It's not clear to me exactly what needs to change to make this happen so I'll defer to @BenHenning on this one.

Alternatives considered

No response

Additional context

No response

[BenHenning]

I suspect that this won't be a problem. I haven't looked into associating click & focus yet beyond a rough feasibility assessment.

One point for clarification, though: why does focus need to happen specifically before the context menu is generated? Is it to ensure that the context menu receives ephemeral focus?

[maribethb]

No, I don't think that specific timing matters after all.

I thought we would need this because I thought the sequence of events would be:

1. user right clicks
2. focus is set to the thing that was right-clicked
3. gesture code checks if the thing implements IContextMenu and if so it calls its showContextMenu function.
4. At this point I thought the gesture code would have to set the focusedNode property for the context menu. But instead, the object will set itself as the focusedNode inside its showContextMenu when it calls the context menu APIs. So because the object will set itself as the focusedNode, it doesn't matter what is actually focused, as long as the gesture code calls the correct object's showContextMenu function (which it already does)

So we don't necessarily need this for the context menu api changes, but I left it open because it's still a case we should check, and because some of the context menu option callbacks might depend on the passive/active focus items being set correctly.

[BenHenning]

Should be addressed with #8981. When I tested right click with the keyboard navigation plugin, it does set active focus now on the block (which then moves to passive focus when the context menu is open).

@maribethb do you have any specific process by which to further test what was needed here, or is there something that now gets unblocked with this working?