Skip to content

Field regressions due to #8738 #9005

Description

@cpcallen

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

PR #8738 fixed issue #8738, but introduced a number of unexpected changes to fields:

  1. Remove of Field.NBSP broke the multiline text input field in a trivial but somewhat gratuitous way.
  2. Removal of code that ensures field display text is at least one character long caused empty inputs to become quite narrow:
    • Before:
      Image
    • After:
      Image
  3. Removal of code that replaces normal spaces with non-breaking spaces causes fields with multiple consecutive spaces to be mis-rendered:
    • Before:
      Image
    • After:
      Image

Reproduction steps

  1. Open playground.
  2. Drag any block with a FieldInput to the workspace.
  3. Enter the empty string.
  4. Enter text with multiple spaces.

Additional observations

  • The change to make empty label fields zero-width appears to be correct and should be retained.
  • It's pretty clear that FieldInput at should have the previous multiple-space-retention behaviour. It's less clear whether ordinary Fields should too, but it looks like there will be a rendering bug if they don't.
  • There doesn't seem to be any reason that empty FieldInputs should be revert to the previous, slightly wider width:

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions