Uh oh!
There was an error while loading. Please reload this page.
refactor(generators): Introduce PythonGenerator class, Order enum - #7163
Merged
cpcallen merged 3 commits intoJun 14, 2023
Merged
Conversation
cpcallen
enabled auto-merge (squash)
June 14, 2023 04:18
BeksOmega
approved these changes
Jun 14, 2023
| * @protected | ||
| */ | ||
| quote_(string) { | ||
| // Can't use goog.string.quote since % must also be escaped. |
Contributor
There was a problem hiding this comment.
nit: remove reference to goog?
CollaboratorAuthor
There was a problem hiding this comment.
Sure. I deleted the comment completely, because we don't use the closure library any more and there didn't appear to be any code that handles % specially (and indeed after checking the python docs I'm not sure why there would be).
cpcallen added a commit
to cpcallen/blockly
that referenced
this pull request
Jun 14, 2023
Addresses various nits that escaped previous PRs: * Add TSDoc for `BlockGenerator` in `core/generator.ts` for PR RaspberryPiFoundation#7150. * Fix bad formating in `generators/javascript.js` from PR RaspberryPiFoundation#7153. * Add missing `@enum` tag that should have been included in PR RaspberryPiFoundation#7160. * Delete obsolete comment from `generators/python.js` for PR RaspberryPiFoundation#7163.
cpcallen added a commit
that referenced
this pull request
Jun 14, 2023
Addresses various nits that escaped previous PRs: * Add TSDoc for `BlockGenerator` in `core/generator.ts` for PR #7150. * Fix bad formating in `generators/javascript.js` from PR #7153. * Add missing `@enum` tag that should have been included in PR #7160. * Delete obsolete comment from `generators/python.js` for PR #7163.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Part of #7085.
Proposed Changes
Introduce a
PythonGeneratorclass to be the class of whichpythonGeneratoris an instance (without any additional properties making it a singleton).Introduce an
Orderenum (for now Closure-style) for the operator precedence table.Don't rename
pythonGeneratortoPythonin generators/python/*.js.Behaviour Before/After Change
There should be no changes in behaviour.
Reason for Changes
See #7085.
Test Coverage
Passes
npm test; no changes to manual testing anticipated.Documentation
Documentation for the
PythonGeneratorclass andOrderenum should be automatically generated by our JSDoc configs.Additional Information
It is now possible to create multiple
pythonGeneratorobjects, which can share (or not share) block generator implementations. Note that new instances do not by default come with any generator functions pre-installed.We now provide an enum of the operator precedence values (order of operations) constants as a separate export:
DEPRECATION: The
.ORDER_*constants onpythonGeneratorare deprecated; they still exist but are no longer part of the documented API and will be removed in a future version of Blockly. We recommend that you update your custom generator code to use theOrderenum at your earliest convenience.