Uh oh!
There was an error while loading. Please reload this page.
fix(demos): Update code demo to use new script import names for generators - #7213
Merged
Merged
Conversation
This is mostly just chore updating to the new import names (e.g. BlocklyJavaScript -> javascript.javascriptGenerator), but the change to Code.checkAllGeneratorFunctionsDefined is a necessary fix due to the breaking change in PR RaspberryPiFoundation#7150, implementing the .forBlock dictionary.
BeksOmega
approved these changes
Jun 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes errors in
Code.checkAllGeneratorFunctionsDefinedcaused by the breaking change in PR #7150, implementing the.forBlockdictionary.Proposed Changes
demos/code/demo to use the new import names (e.g.BlocklyJavaScript->javascript.javascriptGenerator.Code.checkAllGeneratorFunctionsDefinedby having it use.forBlocksdictionary.Behaviour Before Change
Code generation fails with dialog warning about missing generator functions.
Behaviour After Change
Code generation works.
Reason for Changes
Keep code functional and up-to-date.
Test Coverage
Manually tested.