Uh oh!
There was an error while loading. Please reload this page.
chore(tests): update generator test blocks to use forBlock - #7311
Merged
rachel-fenichel merged 1 commit intoJul 28, 2023
Merged
Conversation
NeilFraser
approved these changes
Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes#7303
Proposed Changes
forBlock, as described in refactor(generators)!:CodeGeneratorper-block-type generator function dictionary #7150defineAssertfunctions off theunittest_maingenerator objects, and make sure their names don't collide when loaded in the same page.Behavior Before Change
Lots of deprecation warnings, but everything works.
Behavior After Change
No deprecation warnings, and everything still works.
Reason for Changes
Respond to deprecation.