Skip to content

fix!: Rename editing CSS class to blocklyEditing (#8287) - #8301

Merged
BeksOmega merged 2 commits into
RaspberryPiFoundation:rc/v12.0.0from
ga-fleury:rc/v12.0.0
Jul 22, 2024
Merged

fix!: Rename editing CSS class to blocklyEditing (#8287)#8301
BeksOmega merged 2 commits into
RaspberryPiFoundation:rc/v12.0.0from
ga-fleury:rc/v12.0.0

Conversation

@ga-fleury

@ga-fleuryga-fleury commented Jul 11, 2024•
edited by BeksOmega
Loading

Copy link
Copy Markdown
Contributor

Fixes: #8287

chore!: Rename editing CSS class to blocklyEditing (#8287)

@ga-fleury
ga-fleury requested a review from a team as a code ownerJuly 11, 2024 00:48
@ga-fleury
ga-fleury requested a review from cpcallenJuly 11, 2024 00:48
@conventional-commit-lint-gcf

conventional-commit-lint-gcfBot commented Jul 11, 2024•
edited
Loading

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@github-actionsgithub-actionsBot added breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Jul 11, 2024
@ga-fleuryga-fleury changed the title chore!: Rename editing CSS class to blocklyEditing (#8287)chore!: Rename editing CSS class to blocklyEditingJul 11, 2024
@github-actionsgithub-actionsBot added breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) and removed breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Jul 11, 2024
@ga-fleuryga-fleury changed the title chore!: Rename editing CSS class to blocklyEditingRename editing CSS class to blocklyEditingJul 11, 2024
@github-actionsgithub-actionsBot added breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) and removed breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Jul 11, 2024
@ga-fleuryga-fleury changed the title Rename editing CSS class to blocklyEditingchore!: Rename editing CSS class to blocklyEditingJul 11, 2024
@github-actionsgithub-actionsBot added breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) and removed breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Jul 11, 2024
@ga-fleuryga-fleury changed the title chore!: Rename editing CSS class to blocklyEditingchore!: Rename editing CSS class to blocklyEditing (#8287)Jul 11, 2024
@github-actionsgithub-actionsBot added breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) and removed breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Jul 11, 2024
@github-actionsgithub-actionsBot added breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) and removed breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Jul 11, 2024
@cpcallencpcallen assigned BeksOmega and unassigned cpcallenJul 11, 2024
@github-actionsgithub-actionsBot added breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) and removed breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Jul 11, 2024
@BeksOmega

BeksOmega commented Jul 11, 2024

Copy link
Copy Markdown
Contributor

Yay! Glad it looks like you got the branches sorted :D

Two housekeeping things that apply to all of your PRs:

  1. Commenting on issues is important. Even if I don't assign it to you before you complete it, it lets other folks know it is being worked on, so they can look at other issues.
  2. Filling out the PR template is important. At the bare minimum you need the Fixes: #issue line, because there is GitHub automation associated with that. I'll fix your existing PRs, but for any future PRs you'll have to do this.

Please reply or react to let me know you've seen this!

@ga-fleury

ga-fleury commented Jul 11, 2024

Copy link
Copy Markdown
ContributorAuthor

Yay! Glad it looks like you got the branches sorted :D

Two housekeeping things that apply to all of your PRs:

  1. Commenting on issues is important. Even if I don't assign it to you before you complete it, it lets other folks know it is being worked on, so they can look at other issues.
  2. Filling out the PR template is important. At the bare minimum you need the Fixes: #issue line, because there is GitHub automation associated with that. I'll fix your existing PRs, but for any future PRs you'll have to do this.

Please reply or react to let me know you've seen this!

Will do! thank you for the heads up!

@BeksOmega
BeksOmega requested review from BeksOmega and removed request for cpcallenJuly 11, 2024 16:58
BeksOmega
BeksOmega suggested changes Jul 11, 2024
View reviewed changes

@BeksOmegaBeksOmega left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this in the issue description, but there is also a places in core/field_input where we call dom.removeClass with editing. This needs to be renamed as well.

After that should be gtg!

@BeksOmega

BeksOmega commented Jul 17, 2024

Copy link
Copy Markdown
Contributor

Heya @ga-fleury Are you still interested in working on this?

@ga-fleury

ga-fleury commented Jul 17, 2024

Copy link
Copy Markdown
ContributorAuthor

@BeksOmega added further changes

BeksOmega
BeksOmega approved these changes Jul 22, 2024
View reviewed changes

@BeksOmegaBeksOmega left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for the fixes =)

@BeksOmegaBeksOmega changed the title chore!: Rename editing CSS class to blocklyEditing (#8287)fix!: Rename editing CSS class to blocklyEditing (#8287)Jul 22, 2024
@github-actionsgithub-actionsBot added breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug and removed breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Jul 22, 2024
@BeksOmega
BeksOmega merged commit e29d7ab into RaspberryPiFoundation:rc/v12.0.0Jul 22, 2024
@BeksOmegaBeksOmega mentioned this pull request Jul 22, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@BeksOmegaBeksOmegaBeksOmega approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@BeksOmegaBeksOmega

Labels

breaking changeUsed to mark a PR or issue that changes our public APIs.PR: fixFixes a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ga-fleury@BeksOmega@cpcallen