Uh oh!
There was an error while loading. Please reload this page.
fix: Remove references to getFastTextWidth (#8277) - #8307
Merged
BeksOmega merged 2 commits intoJul 22, 2024
Conversation
BeksOmega
approved these changes
Jul 11, 2024
BeksOmega
left a comment
Contributor
There was a problem hiding this comment.
This looks great! Thank you for the fixes =) I'll get this merged once CI passes.
For future peoples: Pulled this down and did some performance profiling, and impacts were minimal. On a 1k Scatter, self-time for getTextWidth was 0.3%.
BeksOmega
commented
Jul 12, 2024
Contributor
Looks like formatting is failing, you can run |
BeksOmega
suggested changes
Jul 12, 2024
BeksOmega
left a comment
Contributor
There was a problem hiding this comment.
Marking this as changes requested
BeksOmega
commented
Jul 17, 2024
Contributor
Heya @ga-fleury Are you still interested in working on this? |
ga-fleury
commented
Jul 17, 2024
ContributorAuthor
@BeksOmega format changes commited! |
BeksOmega
approved these changes
Jul 22, 2024
BeksOmega
left a comment
Contributor
There was a problem hiding this comment.
Thank you again for your work on this!
1 task
mjgallag added a commit
to mit-cml/blockly
that referenced
this pull request
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8277
feat: Remove references to getFastTextWidth (#8277)