Skip to content

feat: Add a blocklyCollapsed CSS class to collapsed blocks' root SVG (#8264) - #8308

Merged
BeksOmega merged 2 commits into
RaspberryPiFoundation:rc/v12.0.0from
ga-fleury:feature/8264
Jul 22, 2024
Merged

feat: Add a blocklyCollapsed CSS class to collapsed blocks' root SVG (#8264)#8308
BeksOmega merged 2 commits into
RaspberryPiFoundation:rc/v12.0.0from
ga-fleury:feature/8264

Conversation

@ga-fleury

@ga-fleuryga-fleury commented Jul 11, 2024

Copy link
Copy Markdown
Contributor

Fixes: #8264

feat: Add a blocklyCollapsed CSS class to collapsed blocks' root SVG (#8264)

@ga-fleury
ga-fleury requested a review from a team as a code ownerJuly 11, 2024 12:10
@ga-fleury
ga-fleury requested a review from BeksOmegaJuly 11, 2024 12:10
@github-actionsgithub-actionsBot added PR: feature Adds a feature and removed PR: feature Adds a feature labels Jul 11, 2024

@BeksOmegaBeksOmega left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for the fix =)

Once this passes CI I'll get it merged!

@BeksOmega

Copy link
Copy Markdown
Contributor

Looks like this is failing formatting. Please fix the same way I suggested on the other PR!

@BeksOmegaBeksOmega left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this as changes requested

@BeksOmega

Copy link
Copy Markdown
Contributor

Heya @ga-fleury Are you still interested in working on this?

@ga-fleury

Copy link
Copy Markdown
ContributorAuthor

@BeksOmega format changes pushed

@BeksOmegaBeksOmega left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great =) Thanks for your work on this!

@BeksOmega
BeksOmega merged commit 348313a into RaspberryPiFoundation:rc/v12.0.0Jul 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: featureAdds a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ga-fleury@BeksOmega